feat(sync): apply legacy shared review reassignment#1088
Merged
kunickiaj merged 1 commit intoMay 12, 2026
Conversation
Owner
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Adds the explicit apply step for legacy-shared-review groups so reviewed historical rows can be reassigned to a selected Sharing domain without automatic promotion.
The flow previews counts first, requires explicit old-copies confirmation, enforces local device membership for the target domain, rejects local-default/legacy targets, skips peer-owned rows, and keeps the old-copies warning visible.
Type of Change
Testing
pnpm run tsc,pnpm run lint,pnpm run test)Targeted/local checks run:
pnpm exec vitest run packages/viewer-server/src/index.test.ts --testNamePattern "legacy shared review" packages/ui/src/tabs/sync/components/sync-sharing-review.test.tsxpnpm run tscpnpm run lint(passes with existing FeedItemCard info warnings)pnpm --filter @codemem/ui buildgit diff --checkChecklist
pnpm run lintpasses for touched files)