Skip to content

feat(sync): apply legacy shared review reassignment#1088

Merged
kunickiaj merged 1 commit into
mainfrom
05-12-feat_sync_apply_legacy_shared_review_reassignment
May 12, 2026
Merged

feat(sync): apply legacy shared review reassignment#1088
kunickiaj merged 1 commit into
mainfrom
05-12-feat_sync_apply_legacy_shared_review_reassignment

Conversation

@kunickiaj
Copy link
Copy Markdown
Owner

@kunickiaj kunickiaj commented May 12, 2026

Description

Adds the explicit apply step for legacy-shared-review groups so reviewed historical rows can be reassigned to a selected Sharing domain without automatic promotion.

The flow previews counts first, requires explicit old-copies confirmation, enforces local device membership for the target domain, rejects local-default/legacy targets, skips peer-owned rows, and keeps the old-copies warning visible.

Type of Change

  • 🚀 Feature (new functionality)
  • 🐛 Bug fix (fixes an issue)
  • 📚 Documentation (docs-only change)
  • 🔧 Maintenance (refactor, chore, CI, etc.)
  • 🧪 Testing (test-only changes)

Testing

  • Relevant checks pass locally (pnpm run tsc, pnpm run lint, pnpm run test)
  • Added/updated tests for changes
  • Manually verified changes work as expected

Targeted/local checks run:

  • pnpm exec vitest run packages/viewer-server/src/index.test.ts --testNamePattern "legacy shared review" packages/ui/src/tabs/sync/components/sync-sharing-review.test.tsx
  • pnpm run tsc
  • pnpm run lint (passes with existing FeedItemCard info warnings)
  • pnpm --filter @codemem/ui build
  • git diff --check

Checklist

  • Code follows project style (pnpm run lint passes for touched files)
  • Self-review completed
  • Documentation updated (if needed)
  • No new warnings introduced

Copy link
Copy Markdown
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kunickiaj kunickiaj marked this pull request as ready for review May 12, 2026 22:44
Copy link
Copy Markdown
Owner Author

kunickiaj commented May 12, 2026

Merge activity

  • May 12, 11:05 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 12, 11:05 PM UTC: @kunickiaj merged this pull request with Graphite.

@kunickiaj kunickiaj merged commit daec8f8 into main May 12, 2026
8 checks passed
@kunickiaj kunickiaj deleted the 05-12-feat_sync_apply_legacy_shared_review_reassignment branch May 12, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant