Skip to content

feat(ui): manage coordinator sharing domains #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunickiaj merged 1 commit into from
May 6, 2026
Merged

feat(ui): manage coordinator sharing domains #1040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/ui/src/lib/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,25 @@ export { loadConfig, loadObserverStatus, saveConfig } from "./api/config";
export {
archiveCoordinatorAdminGroup,
createCoordinatorAdminGroup,
createCoordinatorAdminScope,
createCoordinatorInvite,
disableCoordinatorAdminDevice,
enableCoordinatorAdminDevice,
grantCoordinatorAdminScopeMember,
loadCoordinatorAdminDevices,
loadCoordinatorAdminGroups,
loadCoordinatorAdminGroupsFiltered,
loadCoordinatorAdminJoinRequests,
loadCoordinatorAdminScopeMembers,
loadCoordinatorAdminScopes,
loadCoordinatorAdminStatus,
removeCoordinatorAdminDevice,
renameCoordinatorAdminDevice,
renameCoordinatorAdminGroup,
reviewCoordinatorAdminJoinRequest,
revokeCoordinatorAdminScopeMember,
unarchiveCoordinatorAdminGroup,
updateCoordinatorAdminScope,
} from "./api/coordinator-admin";
export {
forgetMemory,
Expand Down
4 changes: 4 additions & 0 deletions packages/ui/src/lib/api/coordinator-admin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,17 +76,21 @@ export interface CoordinatorAdminScopePayload {
kind?: string | null;
authority_type?: string | null;
coordinator_id?: string | null;
group_id?: string | null;
manifest_issuer_device_id?: string | null;
membership_epoch?: number | null;
manifest_hash?: string | null;
status?: string | null;
}

export interface CoordinatorAdminScopeMemberPayload {
scope_id?: string;
device_id?: string;
role?: string | null;
status?: string | null;
membership_epoch?: number | null;
coordinator_id?: string | null;
group_id?: string | null;
manifest_issuer_device_id?: string | null;
manifest_hash?: string | null;
signed_manifest_json?: string | null;
Expand Down
75 changes: 66 additions & 9 deletions packages/ui/src/tabs/coordinator-admin/components/groups-panel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ import {
currentAdminTargetGroup,
setAdminTargetGroup,
} from "../data/target-group";
import {
closeGroupScopeManagement,
openGroupScopeManagement,
renderGroupScopeManagementPanel,
} from "./scope-management-panel";

/* Inlined chevron SVG — matches the sync-tab device-row chevron so the
* CSS `[data-state="open"]` rotation style is shared. Avoids depending
Expand Down Expand Up @@ -110,7 +115,7 @@ async function saveGroupPreferences(groupId: string, renderShell: () => void): P
try {
await api.saveCoordinatorGroupPreferences(groupId, payload);
showGlobalNotice(
"Group scope defaults saved. New peers enrolled through this team will use these defaults.",
"Group project defaults saved. New peers enrolled through this team will use these filters.",
);
closeGroupPreferences(groupId, renderShell);
} catch (error) {
Expand All @@ -135,7 +140,7 @@ function renderGroupPreferencesEditor(
const draft = coordinatorAdminState.groupPreferencesDrafts.get(groupId);
if (!draft) return null;
if (!draft.loaded) {
return h("div", { class: "peer-submeta" }, "Loading scope defaults…");
return h("div", { class: "peer-submeta" }, "Loading project defaults…");
}
const autoSeedLabelId = `coord-admin-scope-autoseed-${groupId}`;
const includeLabelId = `coord-admin-scope-include-${groupId}`;
Expand All @@ -144,19 +149,19 @@ function renderGroupPreferencesEditor(
return h(
Fragment,
null,
h("h4", { class: "coordinator-admin-drawer-title" }, "Scope defaults"),
h("h4", { class: "coordinator-admin-drawer-title" }, "Project defaults"),
h(
"div",
{ class: "peer-submeta" },
"When enabled, new peers enrolled through this team start with the project filters below. Existing peers are unchanged.",
"When enabled, new peers enrolled through this coordinator group start with the project filters below. Existing peers are unchanged, and these filters never grant sharing-domain access.",
),
// Master toggle first — the include/exclude chips are only meaningful
// when auto-seed is on, so the form reads top-down from decision
// (toggle) to config (chips).
h(
"label",
{ class: "coordinator-admin-inline-filter" },
h("span", { class: "section-meta", id: autoSeedLabelId }, "Auto-seed scope on new peers"),
h("span", { class: "section-meta", id: autoSeedLabelId }, "Auto-seed project filters"),
h(RadixSwitch, {
"aria-labelledby": autoSeedLabelId,
checked: draft.auto_seed_scope,
Expand Down Expand Up @@ -402,6 +407,7 @@ export function renderGroupsPanel(deps: GroupsPanelDeps) {
group.display_name ??
group.group_id;
const scopeOpen = coordinatorAdminState.groupPreferencesOpen.has(group.group_id);
const domainsOpen = coordinatorAdminState.groupScopeManagementOpen.has(group.group_id);
return h(
"div",
{ class: "peer-card peer-card--padded", key: group.group_id },
Expand Down Expand Up @@ -464,7 +470,7 @@ export function renderGroupsPanel(deps: GroupsPanelDeps) {
"button",
{
"aria-expanded": scopeOpen,
"aria-controls": `coord-admin-scope-drawer-${group.group_id}`,
"aria-controls": `coord-admin-project-defaults-drawer-${group.group_id}`,
class: "settings-button coordinator-admin-scope-trigger",
"data-state": scopeOpen ? "open" : "closed",
disabled: summary.readiness !== "ready" || pending,
Expand All @@ -477,7 +483,31 @@ export function renderGroupsPanel(deps: GroupsPanelDeps) {
},
type: "button",
},
h("span", null, "Scope defaults"),
h("span", null, "Project defaults"),
h(
"span",
{ "aria-hidden": "true", class: "device-row-chevron" },
h(ChevronRightIcon, null),
),
),
h(
"button",
{
"aria-expanded": domainsOpen,
"aria-controls": `coord-admin-domains-drawer-${group.group_id}`,
class: "settings-button coordinator-admin-scope-trigger",
"data-state": domainsOpen ? "open" : "closed",
disabled: summary.readiness !== "ready" || pending,
onClick: () => {
if (domainsOpen) {
closeGroupScopeManagement(group.group_id, renderShell);
} else {
openGroupScopeManagement(group.group_id, renderShell);
}
},
type: "button",
},
h("span", null, "Sharing domains"),
h(
"span",
{ "aria-hidden": "true", class: "device-row-chevron" },
Expand Down Expand Up @@ -520,9 +550,9 @@ export function renderGroupsPanel(deps: GroupsPanelDeps) {
h(
Collapsible.Content,
{
"aria-label": `Scope defaults for ${draftName}`,
"aria-label": `Project defaults for ${draftName}`,
class: "coordinator-admin-group-preferences",
id: `coord-admin-scope-drawer-${group.group_id}`,
id: `coord-admin-project-defaults-drawer-${group.group_id}`,
},
scopeOpen
? renderGroupPreferencesEditor(
Expand All @@ -533,6 +563,33 @@ export function renderGroupsPanel(deps: GroupsPanelDeps) {
: null,
),
),
h(
Collapsible.Root,
{
open: domainsOpen,
onOpenChange: (open: boolean) => {
if (open) openGroupScopeManagement(group.group_id, renderShell);
else closeGroupScopeManagement(group.group_id, renderShell);
},
},
h(
Collapsible.Content,
{
"aria-label": `Sharing domains for ${draftName}`,
class:
"coordinator-admin-group-preferences coordinator-admin-domain-management",
id: `coord-admin-domains-drawer-${group.group_id}`,
},
domainsOpen
? renderGroupScopeManagementPanel({
groupId: group.group_id,
ready: summary.readiness === "ready",
renderShell,
summary,
})
: null,
),
),
);
}),
),
Expand Down
Loading