Skip to content

Commit bdb3b64

Browse files
committed
http: remove closeIdleConnections function while calling server close.
Correcting the nodejs#50194 backporting mistake. closeIdleConnections shouldnot be called while server.close in node v18. This behavior is for node v19 and above. fixes: nodejs#52330, nodejs#51677
1 parent 8c8961d commit bdb3b64

5 files changed

+2
-38
lines changed

lib/_http_server.js

-1
Original file line numberDiff line numberDiff line change
@@ -506,7 +506,6 @@ function setupConnectionsTracking() {
506506
}
507507

508508
function httpServerPreClose(server) {
509-
server.closeIdleConnections();
510509
clearInterval(server[kConnectionsCheckingInterval]);
511510
}
512511

test/parallel/test-http-server-close-destroy-timeout.js

-13
This file was deleted.

test/parallel/test-http-server-close-idle.js

+1
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ server.listen(0, function() {
4242
assert(response.startsWith('HTTP/1.1 200 OK\r\nConnection: keep-alive'));
4343
assert.strictEqual(connections, 2);
4444

45+
server.closeIdleConnections();
4546
server.close(common.mustCall());
4647

4748
// Check that only the idle connection got closed

test/parallel/test-https-server-close-destroy-timeout.js

-24
This file was deleted.

test/parallel/test-https-server-close-idle.js

+1
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ server.listen(0, function() {
5252
assert(response.startsWith('HTTP/1.1 200 OK\r\nConnection: keep-alive'));
5353
assert.strictEqual(connections, 2);
5454

55+
server.closeIdleConnections();
5556
server.close(common.mustCall());
5657

5758
// Check that only the idle connection got closed

0 commit comments

Comments
 (0)