Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print controller version as part of kubectl kudo version #1295

Open
nfnt opened this issue Jan 21, 2020 · 3 comments · May be fixed by #1527
Open

Print controller version as part of kubectl kudo version #1295

nfnt opened this issue Jan 21, 2020 · 3 comments · May be fixed by #1527
Labels
good first issue kind/enhancement

Comments

@nfnt
Copy link
Member

nfnt commented Jan 21, 2020

What would you like to be added:
Currently, kubectl kudo version only prints the current version of the KUDO CLI. It should also print the version of the KUDO controller if the controller is running.

Why is this needed:
Controller and CLI might differ and this could cause issues because backwards-compatibility can't be guaranteed in all cases. Printing the controller version will help detect the cause.
@sivaramsk
Copy link
Contributor

@nfnt - does printing the version of kudo-controller container would do here? or I can get this information anyother way?

@nfnt
Copy link
Member Author

nfnt commented Apr 6, 2020

Yes, that should be enough. Through the Kubernetes API we could check if the KUDO controller pod is running and which version of the image is deployed.

@sivaramsk
Copy link
Contributor

@nfnt - does the below output looks ok to you

KUDO Version: version.Info{GitVersion:"0.11.1", GitCommit:"11985828", BuildDate:"2020-04-02T16:49:35Z", GoVersion:"go1.13.1", Compiler:"gc", Platform:"darwin/amd64"}
KUDO Controller Version: kudobuilder/controller:v0.11.1

Let me know if you have any suggestions to the output.

@sivaramsk sivaramsk linked a pull request May 15, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature add controller version to version command sivaramsk/kudo
3 participants
@sivaramsk @nfnt @zen-dog