Auto tests for PR: kubevirt/kubevirt#1839 #537

sHaggYcaT · 2019-01-07T11:38:22Z

What this PR does / why we need it:

Auto tests for PR: kubevirt/kubevirt#1839

Release note:

NONE

MarSik · 2019-01-07T11:52:28Z

@sHaggYcaT I do not think you have to check all the VM creation, just use those as functions. I am pretty sure there was a way to call a method and create VM from yaml without having to implement everything on you own.

See for example https://github.com/kubevirt/kubevirt-ansible/blob/master/tests/high_performance_vm_test.go#L46

Currently it is very hard to see the test code in all the boilerplate around it.

sHaggYcaT · 2019-01-28T13:50:43Z

@MarSik ^^updated version ^^
Do not ready for merge, but almost done

MarSik

In general it looks reasonable, make sure you properly cleanup the started VMs and check the patterns for your Context and It descriptions, I do not think the text there should repeat

MarSik · 2019-02-15T14:42:53Z

tests/sockets_cores_threads_test.go

+	return arguments
+}
+
+var _ = Describe("numaSupport", func() {


NUMA? This has nothing to do with numa.. guest topology might be better name here. Also shouldn't you annotate this with the test plan ID somehow so the results are automatically connected with it?

NUMA

Just old variable, I'll rename it. I've already rename everything about NUMA, but in this place forget to do it

Also shouldn't you annotate this with the test plan ID somehow so the results are automatically connected with it?

I'm going to do this work it in another PR for all my test plans together. Now I just want to merge this code ASAP (before it outdated, and before it requires rebase/difficult merges, etc)

It was already fixed

MarSik · 2019-02-15T14:45:36Z

tests/sockets_cores_threads_test.go

+	"time"
+)
+
+type Config struct {


Why not reuse the kubevirt/kubernetes API objects?

Could you please show an example?

^^ @MarSik ^^

https://github.com/kubernetes/api/blob/master/core/v1/types.go#L3144 this structure implements the same I think

I've just made it

sHaggYcaT · 2019-02-15T15:12:43Z

make sure you properly cleanup the started VMs

I've tested it in the openshift local installation and in the official CI. If test passed, then everything delete. If not passed, then failed VMI not delete (and it's helpful for debug). It's not problem for github CI, because it creates dedicated environment for each patch. And it's helpful if you run test manually using our internal CI

sHaggYcaT · 2019-02-27T13:56:09Z

@MarSik how to remove "WIP" flag?

lukas-bednar · 2019-03-04T16:08:24Z

@sHaggYcaT could you please try to add following value to LagoInitFile.yml.j2

diff --git a/playbooks/provider/lago/LagoInitFile.yml.j2 b/playbooks/provider/lago/LagoInitFile.yml.j2
index d6fb07ac..8cbcd7a4 100644
--- a/playbooks/provider/lago/LagoInitFile.yml.j2
+++ b/playbooks/provider/lago/LagoInitFile.yml.j2
@@ -6,6 +6,7 @@ nat-settings: &nat-settings
     management: False
 
 vm-common-settings: &vm-common-settings
+    vcpu: 4
     root-password: 123456
     service_provider: systemd
     artifacts:

sHaggYcaT · 2019-03-04T16:24:54Z

@sHaggYcaT could you please try to add following value to LagoInitFile.yml.j2

Thank you @lukas-bednar

lukas-bednar · 2019-03-04T16:27:51Z

playbooks/provider/lago/LagoInitFile.yml.j2

@@ -6,6 +6,7 @@ nat-settings: &nat-settings
    management: False

 vm-common-settings: &vm-common-settings
+    vCpu: 4


it is lowercased vcpu, I am afraid that it might cause that this option is going to be ignored :-O

For further reference, you can following this document: https://lago.readthedocs.io/en/latest/LagoInitFile.html

@lukas-bednar looks like it doesn't work :(

Forget to say, your latest suggestion works

ILpinto · 2019-03-14T15:46:38Z

tests/sockets_cores_threads_test.go

+	return arguments
+}
+
+var _ = Describe("numaSupport", func() {


ILpinto · 2019-03-14T15:51:30Z

tests/framework/util.go

@@ -134,3 +134,55 @@ func RemoveDataVolume(dvName string, namespace string) {
 	err = virtCli.CdiClient().CdiV1alpha1().DataVolumes(namespace).Delete(dvName, nil)
 	Expect(err).ToNot(HaveOccurred())
 }
+
+func CreateVMorVMIfromManifest(manifest, nameSpace string) string {


See tests/framework/types.go
Use: func (vm VirtualMachine) Create() (string, string, error)

ILpinto · 2019-03-14T15:53:06Z

tests/framework/util.go

+
+// Find out how many VMs with specific resource needs can be run in the cluster
+
+func min(a, b int) int {


use https://golang.org/pkg/math/#Min

OK, thank you

ILpinto · 2019-03-14T15:55:35Z

tests/sockets_cores_threads_test.go

+	virtClient, err := kubecli.GetKubevirtClient()
+	ktests.PanicOnError(err)
+	address_common := "tests/manifests/sockets_cores_threads/"
+	const TestSystemNamespace = "kubevirt-test-default"


import
tests "kubevirt.io/kubevirt-ansible/tests/framework"
use like:
tests.NamespaceTestDefault
remove this const

ILpinto · 2019-03-14T15:58:34Z

tests/sockets_cores_threads_test.go

+ *
+ */
+
+package tests_test


Add polarion test ids to all test cases

@ILpinto done

…g; minor improvements

sHaggYcaT · 2019-05-16T17:10:08Z

Failed in webUI deploy:

17:03:26 TASK [kubevirt_web_ui : Wait until Web UI is ready: 'v1.4.0-13'] ***************

vladikr

Looks fine to me now. Some parts of this code could be implemented differently, but I don't see a point on stalling on this now. It probably can be improved in the future or re-implemented on another platform.

Let's wait for the tests to finish.

sHaggYcaT · 2019-05-17T21:37:42Z

@vladikr thank you.
@MarSik permitted few work-arounds to fix CI. So, I not sure, maybe my fixes broken something. In this case let me know please.
my tests finished without errors: check [rfe_id:1443]. So, I'll merge this PR

sHaggYcaT added the WIP label Jan 7, 2019

kubevirt-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L labels Jan 7, 2019

sHaggYcaT changed the title ~~initial~~ Auto tests for PR: kubevirt/kubevirt#1839 Jan 7, 2019

kubevirt-bot added size/XL needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/L labels Jan 28, 2019

sHaggYcaT force-pushed the numa_support branch from 10a2f96 to 6c9d880 Compare January 30, 2019 04:24

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2019

sHaggYcaT mentioned this pull request Feb 8, 2019

Zen topology issue kubevirt/kubevirt#1994

Closed

kubevirt-bot added size/XXL and removed size/XL labels Feb 13, 2019

sHaggYcaT force-pushed the numa_support branch from c50676f to 4ed5d97 Compare February 13, 2019 23:56

MarSik reviewed Feb 15, 2019

View reviewed changes

kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2019

lukas-bednar removed the WIP label Mar 4, 2019

sHaggYcaT force-pushed the numa_support branch from 3a10168 to 0831832 Compare March 4, 2019 16:23

kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2019

lukas-bednar reviewed Mar 4, 2019

View reviewed changes

kubevirt-bot added size/XL size/XXL and removed size/XXL size/XL labels Mar 10, 2019

ILpinto reviewed Mar 14, 2019

View reviewed changes

sHaggYcaT added 15 commits May 16, 2019 13:17

add resources

5efea41

fix pod check & lukas suggestion regrding resources

2b56adf

quick fix

caa422f

revert changes in the framework

526eb00

fix issue in the CI

bb1abe6

implement Lukas suggestions

7c35e1a

add test ids

798397c

make generate

a8a6879

add test ids

1250e81

make generate & delete not-used functions

be496ee

implement suggestions

c47e1d1

make generate

271be9c

implement Vadik suggestions

1889302

revert bad commit

2f88cbf

fix goroutine issue(timeout deleted from code); fix Fedora/cirrous bu…

8fd71c0

…g; minor improvements

sHaggYcaT force-pushed the numa_support branch from 9c56042 to 8fd71c0 Compare May 16, 2019 16:18

sHaggYcaT added 10 commits May 17, 2019 10:03

try to up kubevirt & kubevirt UI versions

4615605

try to revert versions to previos two

13d4800

try to revert version of kubevirtUI image

faa34df

debug

e3aa34d

fix arguments

62bb8f6

up versions

4c49127

up versions

cfb322d

change kubevirt version

9127e42

change kubevirt version

a4eb114

increase timeout

f553d04

vladikr approved these changes May 17, 2019

View reviewed changes

sHaggYcaT merged commit 4d6422a into kubevirt:master May 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto tests for PR: kubevirt/kubevirt#1839 #537

Auto tests for PR: kubevirt/kubevirt#1839 #537

sHaggYcaT commented Jan 7, 2019 •

edited

Loading

MarSik commented Jan 7, 2019

sHaggYcaT commented Jan 28, 2019

MarSik left a comment

MarSik Feb 15, 2019

sHaggYcaT Feb 15, 2019 •

edited

Loading

ILpinto Mar 14, 2019

sHaggYcaT Mar 18, 2019

MarSik Feb 15, 2019

sHaggYcaT Feb 15, 2019

sHaggYcaT Feb 15, 2019

MarSik Feb 15, 2019

sHaggYcaT Feb 27, 2019 •

edited

Loading

sHaggYcaT commented Feb 15, 2019 •

edited

Loading

sHaggYcaT commented Feb 27, 2019

lukas-bednar commented Mar 4, 2019

sHaggYcaT commented Mar 4, 2019

lukas-bednar Mar 4, 2019 •

edited

Loading

sHaggYcaT Mar 25, 2019

sHaggYcaT Apr 3, 2019

ILpinto Mar 14, 2019

ILpinto Mar 14, 2019

sHaggYcaT Mar 25, 2019

ILpinto Mar 14, 2019

sHaggYcaT Mar 14, 2019

sHaggYcaT Mar 25, 2019

ILpinto Mar 14, 2019

sHaggYcaT Mar 25, 2019

ILpinto Mar 14, 2019

sHaggYcaT Apr 3, 2019

sHaggYcaT commented May 16, 2019

vladikr left a comment •

edited

Loading

sHaggYcaT commented May 17, 2019


		// Find out how many VMs with specific resource needs can be run in the cluster

		func min(a, b int) int {

Auto tests for PR: kubevirt/kubevirt#1839 #537

Auto tests for PR: kubevirt/kubevirt#1839 #537

Conversation

sHaggYcaT commented Jan 7, 2019 • edited Loading

MarSik commented Jan 7, 2019

sHaggYcaT commented Jan 28, 2019

MarSik left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sHaggYcaT Feb 15, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sHaggYcaT Feb 27, 2019 • edited Loading

Choose a reason for hiding this comment

sHaggYcaT commented Feb 15, 2019 • edited Loading

sHaggYcaT commented Feb 27, 2019

lukas-bednar commented Mar 4, 2019

sHaggYcaT commented Mar 4, 2019

lukas-bednar Mar 4, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sHaggYcaT commented May 16, 2019

vladikr left a comment • edited Loading

Choose a reason for hiding this comment

sHaggYcaT commented May 17, 2019

sHaggYcaT commented Jan 7, 2019 •

edited

Loading

sHaggYcaT Feb 15, 2019 •

edited

Loading

sHaggYcaT Feb 27, 2019 •

edited

Loading

sHaggYcaT commented Feb 15, 2019 •

edited

Loading

lukas-bednar Mar 4, 2019 •

edited

Loading

vladikr left a comment •

edited

Loading