Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Configuration update issue #267

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Fix Configuration update issue #267

merged 3 commits into from
Mar 9, 2022

Conversation

zzxwill
Copy link
Collaborator

@zzxwill zzxwill commented Mar 7, 2022

Fix #266

Signed-off-by: Zheng Xi Zhou [email protected]

@zzxwill zzxwill marked this pull request as ready for review March 8, 2022 12:50
Signed-off-by: Zheng Xi Zhou <[email protected]>
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #267 (40f0fe2) into master (5be51bb) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   77.40%   77.44%   +0.04%     
==========================================
  Files          19       19              
  Lines        1208     1215       +7     
==========================================
+ Hits          935      941       +6     
- Misses        200      202       +2     
+ Partials       73       72       -1     
Flag Coverage Δ
unit 77.44% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controllers/configuration_controller.go 69.26% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be51bb...40f0fe2. Read the comment docs.

Signed-off-by: Zheng Xi Zhou <[email protected]>
@zzxwill zzxwill merged commit 37972ac into kubevela:master Mar 9, 2022
@zzxwill zzxwill deleted the modified branch March 9, 2022 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the object has been modified
2 participants