Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docs) Fixes broken links from install page #1242

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

timrosenblatt
Copy link
Contributor

Description of your changes

This fixes the links for "Standalone Installation" and "Kubernetes Cluster" on https://kubevela.io/docs/install/

I have:

  • Read and followed KubeVela's contribution process.
  • [n/a] Update sidebar.js if adding a new page.
  • [n/a] Run yarn start to ensure the changes has taken effect.

@chivalryq
Copy link
Member

On which page links are broken? I tried https://kubevela.io/docs/next/install But all links work fine.

@timrosenblatt
Copy link
Contributor Author

timrosenblatt commented Jul 3, 2023

The bug is on https://kubevela.io/docs/install/ , not https://kubevela.io/docs/next/install

At the bottom of this image, the "Standalone Installation" link goes to a 404.

image

This link of "Kubernetes Cluster" also goes to a 404.
image

Copy link
Contributor

@wonderflow wonderflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@wonderflow
Copy link
Contributor

please sign the DCO

@wonderflow wonderflow merged commit dfb06fc into kubevela:main Jul 14, 2023
6 checks passed
@timrosenblatt timrosenblatt deleted the patch-1 branch July 16, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants