Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Graphical page realizes "Parametric Build" #144

Open
daniel-hutao opened this issue Apr 27, 2021 · 12 comments
Open

Proposal: Graphical page realizes "Parametric Build" #144

daniel-hutao opened this issue Apr 27, 2021 · 12 comments

Comments

@daniel-hutao
Copy link
Member

Due to some technical limits, the parameters we entered when creating the "Parametric Build" pipeline can only take effect in config.xml, and the Jenkinsfile generated when the pipeline is drawn cannot get the parameters configured when it is created, so it's difficult to use the graphical page Elegantly create "Parametric Build" pipelines.

I think it is possible to directly provide the "Parametric Build" entry when drawing the pipeline, and remove the "Parametric Build" entry at creating the pipeline, then "Parametric Build" can be perfectly realized and never confuse users anymore.

image

image

/kind proposal
/area devops
/area console

@LinuxSuRen
Copy link
Member

/priority high

@daniel-hutao
Copy link
Member Author

need to add /milestone v3.1.1

@LinuxSuRen
Copy link
Member

need to add /milestone v3.1.1

This is an important improvement. But we don't have the perfect solution now. And we might need to have a design first. I'm not sure if we can put this improvement into milestone v3.1.1.

By the way, milestone v3.1.1 has not to be created yet. https://github.com/kubesphere/kubesphere/milestones

@daniel-hutao
Copy link
Member Author

@LinuxSuRen
I just hope that each requirement has a clear milestone, near or far; It can be started to put v3.1.1, and later if found that it was more appropriate to put it in v3.1.2, just modify it. Just like dozens of issues left over from the v3.0.0 milestonethe, it still released.

@LinuxSuRen
Copy link
Member

Got you. I don't have permission to create milestones. We will do the planning work after the holiday.

@JohnNiang
Copy link
Member

JohnNiang commented Jun 25, 2021

I think this improvement is supposed to be added into milestone v3.2 instead of a patch release.

@LinuxSuRen
Copy link
Member

About the Pipeline parametric setting via UI conflicts with Jenkinsfile. So, I think we should fix it as soon as possible. But we might have a limited capacity to do that.

@JohnNiang
Copy link
Member

Since this is a console issue, I suggest moving this issue to kubepshere console repo.

@LinuxSuRen
Copy link
Member

I prefer keeping it be here before having a design for the improvement. I'm not sure if the backend needs changes.

@JohnNiang
Copy link
Member

/cc @kubesphere/sig-console

@tengxunchao
Copy link

About the Pipeline parametric setting via UI conflicts with Jenkinsfile. So, I think we should fix it as soon as possible. But we might have a limited capacity to do that.

Is there a better solution now?

@LinuxSuRen
Copy link
Member

Is there a better solution now?

I am afraid that we need contributors to help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants