Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow to delete tests #814

Merged
merged 3 commits into from
Jan 20, 2022
Merged

fix: allow to delete tests #814

merged 3 commits into from
Jan 20, 2022

Conversation

exu
Copy link
Member

@exu exu commented Jan 20, 2022

Pull request description

Checklist (choose whats happened)

  • breaking change! (describe)
  • tested locally
  • tested on cluster
  • added new dependencies
  • updated the docs
  • added a test

Breaking changes

Changes

Fixes

vsukhin
vsukhin reviewed Jan 20, 2022
View reviewed changes
Copy link
Collaborator

@vsukhin vsukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple minor notes

cmd/kubectl-testkube/commands/tests/deleteall.go Outdated Show resolved Hide resolved
pkg/api/v1/client/direct.go Outdated Show resolved Hide resolved
@exu exu requested a review from vsukhin January 20, 2022 10:18
@exu exu merged commit 61f1f1b into main Jan 20, 2022
@exu exu deleted the jacek/fix/test-delete branch January 20, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsukhin vsukhin vsukhin approved these changes

@fog1985 fog1985 Awaiting requested review from fog1985

@jasmingacic jasmingacic Awaiting requested review from jasmingacic

@nicufk nicufk Awaiting requested review from nicufk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@exu @vsukhin