Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken TestWorkflow spec.pod.volumes propagation into Pod definition #6196

Open
thradec opened this issue Feb 25, 2025 · 2 comments
Open

Broken TestWorkflow spec.pod.volumes propagation into Pod definition #6196

thradec opened this issue Feb 25, 2025 · 2 comments
Labels
bug 🐛 Something is not working as should be

Comments

@thradec
Copy link

thradec commented Feb 25, 2025

Describe the bug

The definition of volumes in TestWorkflow is not correctly propagated into the Pod definition.

To Reproduce

apiVersion: testworkflows.testkube.io/v1
kind: TestWorkflow
metadata:
  name: mock-test
spec:
  container:
    volumeMounts:
      - name: api-token
        mountPath: /var/run/secrets/tokens
  pod:
    volumes:
      - name: api-token
        projected:
          sources:
            - serviceAccountToken:
                path: api-token
                expirationSeconds: 600
                audience: api
  steps:
    - shell: |
        if [ ! -f /var/run/secrets/tokens/api-token ]; then
          echo "Token not found"
          exit 1
        fi

Expected behavior

The pod definition should contain given volume:

spec:
  volumes:
    - name: api-token
      projected:
        sources:
          - serviceAccountToken:
              audience: api
              expirationSeconds: 600
              path: api-token

but there is only

spec:
  volumes:
    - name: api-token
      emptyDir: {}

Version / Cluster

It works fine with testkube 2.1.30, we observed regression after upgrade to 2.1.95.
Testkube is installed as a standalone agent.
K8s version is 1.31 EKS.

@thradec thradec added the bug 🐛 Something is not working as should be label Feb 25, 2025
@vsukhin
Copy link
Collaborator

vsukhin commented Feb 25, 2025

thank you @thradec for reporting it. will check it out @olensmar @jmorante-ks

@vsukhin
Copy link
Collaborator

vsukhin commented Feb 26, 2025

confirmed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something is not working as should be
Projects
None yet
Development

No branches or pull requests

2 participants