Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/iouring detection #476

Merged
merged 16 commits into from
Feb 13, 2025
Merged

Feature/iouring detection #476

merged 16 commits into from
Feb 13, 2025

Conversation

afek854
Copy link
Contributor

@afek854 afek854 commented Feb 4, 2025

Overview

@afek854
WIP: Added ioring ebpf
015f4d4 
Signed-off-by: Afek Berger <[email protected]>
@afek854
WIP: Added ioring loader
27e6630 
Signed-off-by: Afek Berger <[email protected]>
@afek854
WIP: Added iouring to container watcher
e2a1ba3 
Signed-off-by: Afek Berger <[email protected]>
@afek854
WIP: Added rule & identifier
5b8f678 
Signed-off-by: Afek Berger <[email protected]>
@afek854
WIP: Added tests
daeff47 
Signed-off-by: Afek Berger <[email protected]>
@afek854
WIP: fixed loading bug
b9f5aa2 
Signed-off-by: Afek Berger <[email protected]>
@afek854
WIP: bug
1d53185 
Signed-off-by: Afek Berger <[email protected]>
@afek854
WIP: fixed kernel checkings
1fd5aea 
Signed-off-by: Afek Berger <[email protected]>
@afek854
WIP: fixed comm bug
d549c1c 
Signed-off-by: Afek Berger <[email protected]>
@afek854 afek854 force-pushed the feature/iouring_detection branch from db80684 to fd30749 Compare February 4, 2025 11:47
@afek854 afek854 marked this pull request as ready for review February 4, 2025 11:48
@afek854
updated rule name
dbf553a 
Signed-off-by: Afek Berger <[email protected]>
@afek854 afek854 force-pushed the feature/iouring_detection branch from fd30749 to dbf553a Compare February 4, 2025 11:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

@afek854 afek854 force-pushed the feature/iouring_detection branch from 42d3e59 to 873ea7d Compare February 5, 2025 11:40
@afek854
fixed kernel versions
48eb886 
Signed-off-by: Afek Berger <[email protected]>
@afek854 afek854 force-pushed the feature/iouring_detection branch from 873ea7d to 48eb886 Compare February 5, 2025 11:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

@afek854
fixed tests
db5d62d 
Signed-off-by: Afek Berger <[email protected]>
@afek854 afek854 force-pushed the feature/iouring_detection branch from 3464388 to db5d62d Compare February 6, 2025 08:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

@amitschendel amitschendel self-requested a review February 12, 2025 08:22
amitschendel
amitschendel requested changes Feb 12, 2025
View reviewed changes
pkg/containerwatcher/v1/iouring.go
return nil
}

func (ch *IGContainerWatcher) stopIouringTracing() error {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please call this function? make sure you stop the tracer!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DONE

pkg/ebpf/gadgets/iouring/tracer/bpf/iouring.c
return 0;
}

char _license[] SEC("license") = "GPL";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is

pkg/ruleengine/v1/helpers/iouring/iouring.go Outdated
@@ -0,0 +1,138 @@
package iouring

const (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use this: https://github.com/Iceber/iouring-go/blob/002cfd2e2a9021c13192f3bd4d9023374e38c93f/syscall/types.go#L27

@github-actions GitHub Actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@amitschendel amitschendel added the release Create release label Feb 12, 2025
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

@afek854 afek854 force-pushed the feature/iouring_detection branch from 97b18c8 to b93d2a5 Compare February 13, 2025 07:53
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

@amitschendel amitschendel self-requested a review February 13, 2025 08:28
@afek854 afek854 merged commit 475a813 into main Feb 13, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitschendel amitschendel amitschendel approved these changes

Assignees
No one assigned
Labels
release Create release
Projects
KS PRs tracking
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afek854 @amitschendel