Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/processtree #394

Merged
merged 15 commits into from
Oct 31, 2024
Merged

Feature/processtree #394

merged 15 commits into from
Oct 31, 2024

Conversation

amitschendel
Copy link
Collaborator

Overview

@amitschendel
Adding initial code
f26025c 
Signed-off-by: Amit Schendel <[email protected]>
@amitschendel
Adding updated code
45a4fc0 
Signed-off-by: Amit Schendel <[email protected]>
@amitschendel
Adding base code
7232814 
Signed-off-by: Amit Schendel <[email protected]>
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@amitschendel
Adding error msg
82fce66 
Signed-off-by: Amit Schendel <[email protected]>
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@amitschendel
Adding test for isDescendantOfShim
287844f 
Signed-off-by: Amit Schendel <[email protected]>
@amitschendel
Adding comment
566d594 
Signed-off-by: Amit Schendel <[email protected]>
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@amitschendel amitschendel marked this pull request as ready for review October 30, 2024 11:02
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

matthyx
matthyx previously approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@matthyx matthyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just check comments regarding proc

@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@amitschendel amitschendel requested a review from matthyx October 30, 2024 15:02
matthyx
matthyx previously approved these changes Oct 30, 2024
View reviewed changes
@amitschendel amitschendel requested a review from matthyx October 30, 2024 15:55
matthyx
matthyx previously approved these changes Oct 30, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@amitschendel
Adding pcomm
9fa19fd 
Signed-off-by: Amit Schendel <[email protected]>
@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@github-actions GitHub Actions
Copy link

Summary:

  • License scan: success
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@amitschendel amitschendel requested a review from matthyx October 31, 2024 10:53
@amitschendel amitschendel added the release Create release label Oct 31, 2024
matthyx
matthyx approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@matthyx matthyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@amitschendel amitschendel merged commit 2b2bc24 into main Oct 31, 2024
18 checks passed
@amitschendel amitschendel deleted the feature/processtree branch October 31, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthyx matthyx matthyx approved these changes

@slashben slashben Awaiting requested review from slashben

Assignees
No one assigned
Labels
release Create release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amitschendel @matthyx