Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service.md #7810

Merged
merged 2 commits into from
Mar 26, 2018
Merged

Update service.md #7810

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4e71b6
Update service.md
Mar 22, 2018
974a3e7
Update service.md
Mar 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/concepts/services-networking/service.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,8 @@ cloud provider does not support the feature, the field will be ignored.

**Special notes for Azure**: To use user-specified public type `loadBalancerIP`, a static type
public IP address resource needs to be created first, and it should be in the same resource
group of the cluster. Then you could specify the assigned IP address as `loadBalancerIP`.
group of the cluster. Then you could specify the assigned IP address as `loadBalancerIP`. You
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be updated to show an example of how loadBalancerIP and securityGroupName should be used? The wording as it is highlights that there's things needed, but it's very unclear how to use it or if it's specifically required.

As a suggestion, could you reword this using more imperative, direct english:

Specify the assigned IP address as loadBalancerIP. Verify you have securityGroupName in the cloud provider configuration file.

Or something like that?

have to specify `securityGroupName` in the cloud provider configuration file.

#### Internal load balancer
In a mixed environment it is sometimes necessary to route traffic from services inside the same VPC.
Expand Down