Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified use of YAML for Secret example #5418

Merged
merged 2 commits into from
Sep 12, 2017
Merged

Unified use of YAML for Secret example #5418

merged 2 commits into from
Sep 12, 2017

Conversation

kairen
Copy link

@kairen kairen commented Sep 12, 2017

Feature request #5416.

The commit modified confusion example files, all example unified use of YAML, and remove any namespace in YAML.


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 12, 2017
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview ready!

Built with commit 076a5e0

https://deploy-preview-5418--kubernetes-io-master-staging.netlify.com

Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zacharysarah zacharysarah merged commit 97f089e into kubernetes:master Sep 12, 2017
chenopis added a commit that referenced this pull request Sep 15, 2017
…hub.io into chenopis-user-journeys

* 'master' of https://github.com/kubernetes/kubernetes.github.io: (60 commits)
  fix the command output
  ZTE-SH-CN-run-application-run-single-instance-stateful-application-pr-2017-… (#5363)
  Add a note to static pod manifest scanning
  revert WordPress and MySQL PV doc changes to use apps/v1beta2 APIs (#5461)
  Fix pod probes yaml file
  Redirect v1 docs. (#5460)
  Fix error link (#5459)
  Adds link to Calico install instructions (#5423)
  update wordpress and mysql PV doc to use apps/v1beta2 APIs (#5424)
  Fix init containers code block (#5428)
  Link cassandra statefulset tutorial from the guide (#5446)
  Link to persistent volume tutorial from concept doc (#5447)
  fix typos in /admin/authorization/rbac.md (#5427)
  Typo in environment variable
  Fix typo and examples
  Fix typo in deployment documentation
  Unified use of YAML for Secret example (#5418)
  Remove manual deploy on Ubuntu
  fix typo of configure-volume-storage
  fix the command output
  ...
jesscodez pushed a commit that referenced this pull request Sep 22, 2017
* Unified use of YAML for Secret example

* Fix dotfiles in secret volume yaml
@kairen kairen deleted the update-secret branch October 3, 2017 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants