Skip to content

Correct out-of-service taint link to non-graceful node shutdown #51354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Correct out-of-service taint link to non-graceful node shutdown #51354

merged 1 commit into from
Jun 24, 2025

Conversation

@nixpanic
Copy link
Member

@nixpanic nixpanic commented Jun 23, 2025

Description

The non-graceful shutdown documentation has been moved, this link now pointed to a non-existing paragraph.

The node shutdown documentation is part of the cluster-administration guide, so point readers there.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 23, 2025
@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/en Issues or PRs related to English language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 23, 2025
@netlify
Copy link

netlify bot commented Jun 23, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e240e2a
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6859687ea160d10008544a69
😎 Deploy Preview https://deploy-preview-51354--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

dipesh-rawat
dipesh-rawat reviewed Jun 23, 2025
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nixpanic Thanks for your contribution. It appears that this PR includes changes to files across multiple languages (English and Chinese). However, docs follows different processes for each localization, and we typically don't accept pull requests that impact multiple languages simultaneously. I would recommend modify only the primary website content (which means only English content) initially with this PR. Localization updates can be addressed separately after merge of English content.

@dipesh-rawat
Copy link
Member

dipesh-rawat commented Jun 23, 2025

Explicit hold until this PR only covers one language.
(Ok to unhold once that's done)
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2025
@nixpanic
Correct out-of-service taint link to non-graceful node shutdown
e240e2a 
The non-graceful shutdown documentation has been moved, this link now
pointed to a non-existing paragraph.

The node shutdown documentation is part of the cluster-administration
guide, so point readers there.
@nixpanic nixpanic force-pushed the non-graceful-shutdown branch from 45d35cb to e240e2a Compare June 23, 2025 14:45
@nixpanic
Copy link
Member Author

nixpanic commented Jun 23, 2025

Explicit hold until this PR only covers one language. (Ok to unhold once that's done)

Thanks @dipesh-rawat, I've dropped the change in the Chinese translation.

@windsonsea
Copy link
Member

windsonsea commented Jun 24, 2025

/remove-language zh
/unhold

@k8s-ci-robot k8s-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/zh Issues or PRs related to Chinese language labels Jun 24, 2025
@dipesh-rawat
Copy link
Member

dipesh-rawat commented Jun 24, 2025

/remove-area localization

@k8s-ci-robot k8s-ci-robot removed the area/localization General issues or PRs related to localization label Jun 24, 2025
dipesh-rawat
dipesh-rawat reviewed Jun 24, 2025
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/approve

content/en/docs/reference/labels-annotations-taints/_index.md

{{< caution >}}
Refer to [Non-graceful node shutdown](/docs/concepts/architecture/nodes/#non-graceful-node-shutdown)
Refer to [Non-graceful node shutdown](/docs/concepts/cluster-administration/node-shutdown/#non-graceful-node-shutdown)
Copy link
Member

@dipesh-rawat dipesh-rawat Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated link looks correct.
Preview Page

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 24, 2025

LGTM label has been added.

Git tree hash: ae70be10c385903a5dddc121066fa66b92dcc2ea

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7cd26af into kubernetes:main Jun 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@windsonsea windsonsea Awaiting requested review from windsonsea

1 more reviewer

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dipesh-rawat dipesh-rawat

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nixpanic @dipesh-rawat @windsonsea @k8s-ci-robot