Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix busybox image to version 1.28 #31989

Merged
merged 1 commit into from
Mar 25, 2022
Merged

fix busybox image to version 1.28 #31989

merged 1 commit into from
Mar 25, 2022

Conversation

guettli
Copy link
Contributor

@guettli guettli commented Mar 1, 2022 •
edited
Loading

The current busybox image has issues with nslookup.

This confuses users again and again.

This PR fixes the image to busybox:1.28.

Closes #31930

Related issues:

 https://github.com/docker-library/busybox/issues/48
 https://github.com/kubernetes/kubernetes/issues/66924

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/de Issues or PRs related to German language language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pt Issues or PRs related to Portuguese language language/ru Issues or PRs related to Russian language language/vi Issues or PRs related to Vietnamese language labels Mar 1, 2022
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 1, 2022
@guettli guettli mentioned this pull request Mar 1, 2022
Closed
@netlify
Copy link

netlify bot commented Mar 1, 2022 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 7122a44

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/621fca2114b49d00077a89a9

😎 Browse the preview: https://deploy-preview-31989--kubernetes-io-main-staging.netlify.app

sftim
sftim requested changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guettli please restrict this change to just English, as per https://kubernetes.io/docs/contribute/new-content/#languages-per-pr

Making these changes across lots of localizations is problematic because each localization team already has a workflow for adapting changes that are made to English.

Please also update the PR description to make it clear why this change is required and appropriate. If you omit that justification, you're expecting reviewers to provide that context themselves.

@guettli
fix busybox image to 1.28 (issues with nslookup).
7122a44 
Changes where done with these commands:

reprec 'image: busybox(?!:)' 'image: busybox:1.28' */docs */examples
reprec -- '--image=busybox(?!:)' '--image=busybox:1.28' */docs */examples

Related issues:

 docker-library/busybox#48
 kubernetes/kubernetes#66924
@guettli guettli force-pushed the 31930__fix_busybox_image_1.28 branch from 009696f to 7122a44 Compare March 2, 2022 19:48
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 2, 2022
@guettli
Copy link
Contributor Author

guettli commented Mar 2, 2022

@sftim thank you for looking into my PR. I updated the PR to only change "en". I added two links to related issues which explain the issue in depth. Please let me know if there is anything which I need to do.

@kbhawkey
Copy link
Contributor

kbhawkey commented Mar 3, 2022

/remove-language de es fr id it

@k8s-ci-robot k8s-ci-robot removed language/de Issues or PRs related to German language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language labels Mar 3, 2022
@k8s-ci-robot k8s-ci-robot removed the language/it Issues or PRs related to Italian language label Mar 3, 2022
@kbhawkey
Copy link
Contributor

kbhawkey commented Mar 3, 2022

/remove-language ja ko pt ru vi zh

@k8s-ci-robot k8s-ci-robot removed language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pt Issues or PRs related to Portuguese language language/ru Issues or PRs related to Russian language language/vi Issues or PRs related to Vietnamese language language/zh Issues or PRs related to Chinese language labels Mar 3, 2022
@tengqm
Copy link
Contributor

tengqm commented Mar 25, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2022
@guettli guettli requested a review from sftim March 25, 2022 12:05
@reylejano
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 49ff9635fea0b4103a46e7ffdf4df18751cef6ba

@k8s-ci-robot k8s-ci-robot merged commit 39fd63b into kubernetes:main Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bells17 bells17 Awaiting requested review from bells17

@chenrui333 chenrui333 Awaiting requested review from chenrui333

@sftim sftim Awaiting requested review from sftim

Assignees

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvement for k8s.io/docs/tasks/debug-application-cluster/debug-running-pod/
6 participants
@guettli @kbhawkey @tengqm @k8s-ci-robot @reylejano @sftim