Skip to content

Add description of distribute-cpus-across-numa CPUManager policy option #30468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2021
Merged

Add description of distribute-cpus-across-numa CPUManager policy option #30468

merged 1 commit into from
Nov 20, 2021

Conversation

@klueska
Copy link
Contributor

@klueska klueska commented Nov 13, 2021

Add documentation of the new distribute-cpus-across-numa CPUManager policy option.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 13, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 13, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 13, 2021
@klueska klueska mentioned this pull request Nov 13, 2021
Closed
12 tasks
@klueska
Copy link
Contributor Author

klueska commented Nov 13, 2021 •
edited
Loading

/cc @fromanirh @swatisehgal

@netlify
Copy link

netlify bot commented Nov 13, 2021 •
edited
Loading

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: cbb26fe

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/61924b4796df8b0009d73171

😎 Browse the preview: https://deploy-preview-30468--kubernetes-io-main-staging.netlify.app

@ffromani
Copy link
Contributor

(reviewd the KEP and the implementation PR)
content-wise LGTM

@RinkiyaKeDad
Copy link
Member

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Nov 15, 2021
RinkiyaKeDad
RinkiyaKeDad reviewed Nov 15, 2021
View reviewed changes
Copy link
Member

@RinkiyaKeDad RinkiyaKeDad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @fromanirh can you please give an explicit /lgtm from SIG Node before we can merge this?

@ffromani
Copy link
Contributor

/lgtm
for sig-node content

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a852484c22d80c7f5ba4244c26de97338dafde67

@klueska klueska force-pushed the kep-2902-distribute-cpus-policy branch from c1c91b3 to ce89b86 Compare November 15, 2021 11:05
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2021
swatisehgal
swatisehgal reviewed Nov 15, 2021
View reviewed changes
content/en/docs/tasks/administer-cluster/cpu-management-policies.md

#### Static policy options

The following policy options exist for the static `CPUManager` policy:
Copy link
Contributor

@swatisehgal swatisehgal Nov 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should clearly indicate here which of the following options are visible by default and the ones that are not and how that can be achieved by using feature gates. The feature gates part is covered in #29709 but I think we should add a subsection:
##### Alpha options (hidden by default) and move the content corresponding to distribute-cpus-across-numa option that we have here to that subsection.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having a whole subsection, for each, I think it might be sufficient (if not better) to just list these as:

  • full-pcpus-only (beta, visible by default)
  • distribute-cpus-across-numa (alpha, hidden by default)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we only have two options at the moment so doesn't make much difference. When more options are introduced and the list grows we might want to better represent this information so we can clearly see all the options that are visible by default and the ones that are hidden.

@klueska klueska force-pushed the kep-2902-distribute-cpus-policy branch from ce89b86 to cbb26fe Compare November 15, 2021 11:57
@swatisehgal
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 043f86dfb1b76ecc717f065818d07c5d3a87a64b

@ffromani
Copy link
Contributor

/lgtm

@jlbutler
Copy link
Contributor

@klueska can you re-target this PR to dev-1.23 branch please?

@jlbutler
Copy link
Contributor

/assign

@klueska klueska changed the base branch from main to dev-1.23 November 17, 2021 19:40
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 17, 2021
@klueska
Copy link
Contributor Author

klueska commented Nov 17, 2021

Retargeted

@klueska klueska force-pushed the kep-2902-distribute-cpus-policy branch from cbb26fe to 378fc57 Compare November 17, 2021 22:20
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 17, 2021
@netlify
Copy link

netlify bot commented Nov 17, 2021

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 378fc57

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6195801bca04eb0007c4d489

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 17, 2021
ffromani
ffromani reviewed Nov 18, 2021
View reviewed changes
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
after rebase

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 27aaa2ff59c553c62f309f8a6ebfece140e3a55f

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2021
@jlbutler
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlbutler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 04d2006 into kubernetes:dev-1.23 Nov 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the 1.23 milestone Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ConnorDoyle ConnorDoyle Awaiting requested review from ConnorDoyle

@sjenning sjenning Awaiting requested review from sjenning

3 more reviewers

@swatisehgal swatisehgal swatisehgal left review comments

@ffromani ffromani ffromani left review comments

@RinkiyaKeDad RinkiyaKeDad RinkiyaKeDad left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jlbutler jlbutler

@swatisehgal swatisehgal

@ffromani ffromani

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

1.23

Development

Successfully merging this pull request may close these issues.

6 participants

@klueska @ffromani @RinkiyaKeDad @k8s-ci-robot @swatisehgal @jlbutler