Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh] sync kubelet-garbage-collection.md #25749

Merged
merged 1 commit into from
Dec 23, 2020
Merged

[zh] sync kubelet-garbage-collection.md #25749

merged 1 commit into from
Dec 23, 2020

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Dec 21, 2020

sync PR #25457

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 21, 2020
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 21, 2020
@netlify
Copy link

netlify bot commented Dec 21, 2020 •
edited
Loading

✔️ Deploy preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: 369b94c

🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5fe149351c660100083fe44d

😎 Browse the preview: https://deploy-preview-25749--kubernetes-io-master-staging.netlify.app

@Arhell
Copy link
Member Author

Arhell commented Dec 21, 2020

/assign @tengqm

tengqm
tengqm reviewed Dec 22, 2020
View reviewed changes
content/zh/docs/concepts/cluster-administration/kubelet-garbage-collection.md Outdated
@@ -1,25 +1,24 @@
---
title: 配置 kubelet 垃圾回收策略
title: 容器图像的垃圾收集
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: 容器图像的垃圾收集
title: 容器镜像的垃圾收集

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
Thank you

content/zh/docs/concepts/cluster-administration/kubelet-garbage-collection.md Outdated

External garbage collection tools are not recommended as these tools can potentially break the behavior of kubelet by removing containers expected to exist.
-->

垃圾回收是 kubelet 的一个有用功能，它将清理未使用的镜像和容器。
垃圾回收是 kubelet 的一个有用功能，它将清理未使用的镜[像](/zh/docs/concepts/containers/#container-images)和[容器](/zh/docs/concepts/containers/)。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
垃圾回收是 kubelet 的一个有用功能，它将清理未使用的镜[像](/zh/docs/concepts/containers/#container-images)和[容器](/zh/docs/concepts/containers/)。
垃圾回收是 kubelet 的一个有用功能，它将清理未使用的[镜像](/zh/docs/concepts/containers/#container-images)和[容器](/zh/docs/concepts/containers/)。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
Thank you

@tengqm
Copy link
Contributor

tengqm commented Dec 22, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2020
@howieyuen
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dbab07185a6047db964b0839e1ce9ee14427addb

@k8s-ci-robot k8s-ci-robot merged commit 7acb137 into kubernetes:master Dec 23, 2020
@Arhell Arhell deleted the sync branch December 23, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@idealhack idealhack Awaiting requested review from idealhack

Assignees

@tengqm tengqm

@howieyuen howieyuen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Arhell @tengqm @k8s-ci-robot @howieyuen