Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retitle “Configuring kubelet Garbage Collection" #25457

Merged
merged 1 commit into from
Dec 19, 2020
Merged

Retitle “Configuring kubelet Garbage Collection" #25457

merged 1 commit into from
Dec 19, 2020

Conversation

Kartik494
Copy link
Contributor

This PR fixes #25300

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2020
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Dec 7, 2020
@netlify
Copy link

netlify bot commented Dec 7, 2020 •
edited
Loading

✔️ Deploy preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: 7f45bcc

🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5fdcbe187ca0800007339189

😎 Browse the preview: https://deploy-preview-25457--kubernetes-io-master-staging.netlify.app

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2020
kbhawkey
kbhawkey reviewed Dec 17, 2020
View reviewed changes
content/en/docs/concepts/cluster-administration/garbage-collection-container-images.md Outdated
content_type: concept
weight: 70
---

<!-- overview -->

Garbage collection is a helpful function of kubelet that will clean up unused images and unused containers. Kubelet will perform garbage collection for containers every minute and garbage collection for images every five minutes.
Garbage collection is a helpful function of kubelet that will clean up unused [images](https://kubernetes.io/docs/concepts/containers/#container-images) and unused [containers](https://kubernetes.io/docs/concepts/containers/). Kubelet will perform garbage collection for containers every minute and garbage collection for images every five minutes.
Copy link
Contributor

@kbhawkey kbhawkey Dec 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kartik494 .
Do you want to link to the containers page from the GC page or the other way around?
Also, I suggest to write the links as:

[containers](/docs/concepts/containers/)

If you change the name of the file (not sure if required), you will want to add a redirect for the original page?
See website/static/_redirects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kbhawkey i agreed i will be changing the title only and change the name of file to the original one and i will be updated the link as you mentioned .
Thanks

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2020
@Kartik494
Copy link
Contributor Author

Kartik494 commented Dec 18, 2020 •
edited
Loading

Hi @kbhawkey while i addressing the comments i observe that it took the domain name for github rather than k8s.io (https://github.com/kubernetes/website/blob/master/content/en/docs/concepts/cluster-administration/docs/concepts/containers/#container-images) , so should i keep the link as (https://kubernetes.io/docs/concepts/containers/#container-images)

Thanks

kbhawkey
kbhawkey reviewed Dec 18, 2020
View reviewed changes
content/en/docs/concepts/cluster-administration/kubelet-garbage-collection.md Outdated
content_type: concept
weight: 70
---

<!-- overview -->

Garbage collection is a helpful function of kubelet that will clean up unused images and unused containers. Kubelet will perform garbage collection for containers every minute and garbage collection for images every five minutes.
Garbage collection is a helpful function of kubelet that will clean up unused [images](docs/concepts/containers/#container-images) and unused [containers](docs/concepts/containers/). Kubelet will perform garbage collection for containers every minute and garbage collection for images every five minutes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kartik494 .
Would you add a forward slash before the link path:
/docs/concepts/containers/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kbhawkey i have addressed the comment as you suggested , but its again give the link address https://github.com/kubernetes/website/blob/master/docs/concepts/containers/#container-images not expected as k8s.io domain , could you please suggest!

@kbhawkey
Copy link
Contributor

Page preview:
https://deploy-preview-25457--kubernetes-io-master-staging.netlify.app/docs/concepts/cluster-administration/kubelet-garbage-collection/

@kbhawkey
Copy link
Contributor

Hi @Kartik494 . Looks great! ❇️
The links from the GC cluster-administration page to the container page seem fine.
@sftim, the issue suggested:

Hyperlink from within https://kubernetes.io/docs/concepts/containers/ to the page https://kubernetes.io/docs/concepts/cluster-administration/kubelet-garbage-collection/

Instead, do you want to add a link to the GC page from this page:
https://deploy-preview-25457--kubernetes-io-master-staging.netlify.app/docs/concepts/containers/#what-s-next

@kbhawkey
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2020
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 55a2f2af7f8383be425e23964f9cbf670d48981a

@tengqm
Copy link
Contributor

tengqm commented Dec 19, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit fad300a into kubernetes:master Dec 19, 2020
@Arhell Arhell mentioned this pull request Dec 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbhawkey kbhawkey kbhawkey left review comments

@kbarnard10 kbarnard10 Awaiting requested review from kbarnard10

Assignees

@kbhawkey kbhawkey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retitle “Configuring kubelet Garbage Collection” and add incoming links
4 participants
@Kartik494 @kbhawkey @k8s-ci-robot @tengqm