Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate tutorials/stateless-application/ in Korean #12008

Merged
merged 3 commits into from
Jan 4, 2019
Merged

Translate tutorials/stateless-application/ in Korean #12008

merged 3 commits into from
Jan 4, 2019

Conversation

Swalloow
Copy link

@Swalloow Swalloow commented Jan 1, 2019

This PR translates content/en/docs/tutorials/stateless-application directory and the followings which is required to pass the hugo build.

  • content/ko/examples/application/guestbook/frontend-deployment.yaml
  • content/ko/examples/application/guestbook/frontend-service.yaml
  • content/ko/examples/application/guestbook/redis-master-deployment.yaml
  • content/ko/examples/application/guestbook/redis-master-service.yaml
  • content/ko/examples/application/guestbook/redis-slave-deployment.yaml
  • content/ko/examples/application/guestbook/redis-slave-service.yaml

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 1, 2019
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. language/ko Issues or PRs related to Korean language labels Jan 1, 2019
@Swalloow
Copy link
Author

Swalloow commented Jan 1, 2019

I signed it.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 1, 2019
@gochist
Copy link
Member

gochist commented Jan 2, 2019

fixes #11999

gochist
gochist reviewed Jan 2, 2019
View reviewed changes
Copy link
Member

@gochist gochist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Swalloow 감사합니다! 몇 가지 검토 의견 드렸습니다. 참고를 요청드린 건은 선택적으로 반영 바랍니다.

content/ko/docs/tutorials/stateless-application/expose-external-ip-address.md Outdated Show resolved Hide resolved
content/ko/docs/tutorials/stateless-application/guestbook.md Outdated Show resolved Hide resolved
content/ko/docs/tutorials/stateless-application/guestbook.md Outdated Show resolved Hide resolved
content/ko/docs/tutorials/stateless-application/expose-external-ip-address.md Outdated Show resolved Hide resolved
content/ko/docs/tutorials/stateless-application/expose-external-ip-address.md Outdated Show resolved Hide resolved
content/ko/docs/tutorials/stateless-application/guestbook.md Outdated Show resolved Hide resolved
content/ko/docs/tutorials/stateless-application/guestbook.md Outdated Show resolved Hide resolved
content/ko/docs/tutorials/stateless-application/expose-external-ip-address.md Outdated Show resolved Hide resolved
@Swalloow
Copy link
Author

Swalloow commented Jan 2, 2019

@gochist 의견 반영하였습니다. 감사합니다!

gochist
gochist reviewed Jan 4, 2019
View reviewed changes
Copy link
Member

@gochist gochist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Swalloow 감사합니다! 한 번만 더 수정 바랍니다.

content/ko/docs/tutorials/stateless-application/guestbook.md Outdated

### `NodePort`를 통해 프론트엔드 서비스 확인하기

애플리케이션을 Minikube 또는 로컬 클러스터에 디플로이먼트한 경우, 방명록을 보려면 IP 주소를 찾아야 한다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/디플로이먼트한/배포한/

API 오브젝트 Deployment인 경우에만 '디플로이먼트'로 옮기고 있습니다.

content/ko/docs/tutorials/stateless-application/guestbook.md Outdated

### `LoadBalancer`를 통해 프론트엔드 서비스 확인하기

`frontend-service.yaml` 매니페스트를 `LoadBalancer`와 함께 디플로이먼트한 경우, 방명록을 보기 위해 IP 주소를 찾아야 한다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

상동

@Swalloow
Copy link
Author

Swalloow commented Jan 4, 2019

@gochist 추가 수정 반영했습니다!

@gochist
Copy link
Member

gochist commented Jan 4, 2019

@Swalloow 감사합니다!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gochist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 797294f into kubernetes:dev-1.13-ko.4 Jan 4, 2019
seokho-son pushed a commit to seokho-son/website that referenced this pull request Jan 7, 2019
@Swalloow @seokho-son
Translate tutorials/stateless-application/ in Korean (kubernetes#12008)
596ed28 
* Translate tutorials/stateless-application/ in Korean

* Apply comments

* Fix deployment related typos
@claudiajkang claudiajkang mentioned this pull request Jan 16, 2019
Merged
k8s-ci-robot pushed a commit that referenced this pull request Jan 16, 2019
@claudiajkang @k8s-ci-robot
Fourth Korean l10n work for release-1.13 (#12242)
848a46a 
* ko-trans: Fix broken page index for concepts/overview (#11533)

* ko-trans: Update outdated files in dev-1.13-ko.4 (#11544)

* 1. Translate naturally (#11759)

2. Fix markdown error

* ko-trans: Translate building-from-source.md (#11893)

* ko-trans: Translate building-from-source.md

* Address comments

* Update etcd.md (#11976)

* ko-trans: Translate ko/_index.html into Korean (#11937)

* ko-trans: Translate ko/_index.html into Korean.

* Reflect a translation comment. Translate ko/_index.html into Korean

* ko-trans: Translate online-training/overview.md (#11932)

* ko-trans: Translate node-conformance.md (#11907)

* ko-trans: Translate node-conformance.md

* Replace 명세 with 매니페스트.

* Address comments

* ko-trans: Translate tutorials/configuration (#11933)

* ko-trans: Translate `tutorials/configuration` directory

* Address comments

* ko-trans: content/ko/docs/reference/glossary/controller.md (#11994)

* ko-trans: Controller

ko-trans: Controller

* the feedback applied.

the feedback applied.

* minor edit

minor edit

* minor edit #2

minor edit #2

* ko-trans: reference/glossary/kube-apiserver.md (#12024)

ko-trans: reference/glossary/kube-apiserver.md

* Translate tutorials/stateless-application/ in Korean (#12008)

* Translate tutorials/stateless-application/ in Korean

* Apply comments

* Fix deployment related typos

* Translate content/ko/docs/concepts/architecture/nodes in Korean #11748 (#11850)

* Translate content/ko/docs/concepts/architecture/nodes in Korean #11748

* Translate content/ko/docs/concepts/architecture/nodes in Korean #11748

* Translate content/ko/docs/concepts/architecture/nodes in Korean #11748

* Translate concepts/workloads/pods/pod-lifecycle in Korean (#12054)

* Translate concepts/workloads/pods/pod-lifecycle in Korean

* apply review ko-translate concepts/.../pod-lifecycle

* ko-trans: kube-controller-manager.md (#12077)

ko-trans: docs/reference/glossary/kube-controller-manager.md

* fix Italic syntax markdown error (#12128)

* Translate tasks/_index.md in Korean (#12126)

* Translate tasks/_index.md in Korean

* Apply review for Translate tasks/_index.md in Korean

Apply comments for Translate tasks/_index.md in Korean

* Translate setup/_index.md in Korean (#12067)

* Translate setup/_index.md in Korean

* Update setup/_index.md for Korean term consistency

* ko-trans: docs/setup/custom-cloud/kops.md (#11904)

* ko-trans: concepts/overview/working-with-objects/names (#11758)

* ko-trans: /docs/concepts/overview/working-with-objects/namespaces.md (#11773)

* Translate setup/cri.md in Korean (#12174)

* Translate setup/cri.md in Korean

* Apply review, Translate setup/cri.md in Korean

* Translate tasks/tools/install-minikube in Korean (#12176)

* Translate tasks/tools/install-minikube in Korean

* Apply review,Trans tasks/tools/install-minikube in KO
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Jan 29, 2019
@claudiajkang @bsalamat
Fourth Korean l10n work for release-1.13 (kubernetes#12242)
2fd294a 
* ko-trans: Fix broken page index for concepts/overview (kubernetes#11533)

* ko-trans: Update outdated files in dev-1.13-ko.4 (kubernetes#11544)

* 1. Translate naturally (kubernetes#11759)

2. Fix markdown error

* ko-trans: Translate building-from-source.md (kubernetes#11893)

* ko-trans: Translate building-from-source.md

* Address comments

* Update etcd.md (kubernetes#11976)

* ko-trans: Translate ko/_index.html into Korean (kubernetes#11937)

* ko-trans: Translate ko/_index.html into Korean.

* Reflect a translation comment. Translate ko/_index.html into Korean

* ko-trans: Translate online-training/overview.md (kubernetes#11932)

* ko-trans: Translate node-conformance.md (kubernetes#11907)

* ko-trans: Translate node-conformance.md

* Replace 명세 with 매니페스트.

* Address comments

* ko-trans: Translate tutorials/configuration (kubernetes#11933)

* ko-trans: Translate `tutorials/configuration` directory

* Address comments

* ko-trans: content/ko/docs/reference/glossary/controller.md (kubernetes#11994)

* ko-trans: Controller

ko-trans: Controller

* the feedback applied.

the feedback applied.

* minor edit

minor edit

* minor edit kubernetes#2

minor edit kubernetes#2

* ko-trans: reference/glossary/kube-apiserver.md (kubernetes#12024)

ko-trans: reference/glossary/kube-apiserver.md

* Translate tutorials/stateless-application/ in Korean (kubernetes#12008)

* Translate tutorials/stateless-application/ in Korean

* Apply comments

* Fix deployment related typos

* Translate content/ko/docs/concepts/architecture/nodes in Korean kubernetes#11748 (kubernetes#11850)

* Translate content/ko/docs/concepts/architecture/nodes in Korean kubernetes#11748

* Translate content/ko/docs/concepts/architecture/nodes in Korean kubernetes#11748

* Translate content/ko/docs/concepts/architecture/nodes in Korean kubernetes#11748

* Translate concepts/workloads/pods/pod-lifecycle in Korean (kubernetes#12054)

* Translate concepts/workloads/pods/pod-lifecycle in Korean

* apply review ko-translate concepts/.../pod-lifecycle

* ko-trans: kube-controller-manager.md (kubernetes#12077)

ko-trans: docs/reference/glossary/kube-controller-manager.md

* fix Italic syntax markdown error (kubernetes#12128)

* Translate tasks/_index.md in Korean (kubernetes#12126)

* Translate tasks/_index.md in Korean

* Apply review for Translate tasks/_index.md in Korean

Apply comments for Translate tasks/_index.md in Korean

* Translate setup/_index.md in Korean (kubernetes#12067)

* Translate setup/_index.md in Korean

* Update setup/_index.md for Korean term consistency

* ko-trans: docs/setup/custom-cloud/kops.md (kubernetes#11904)

* ko-trans: concepts/overview/working-with-objects/names (kubernetes#11758)

* ko-trans: /docs/concepts/overview/working-with-objects/namespaces.md (kubernetes#11773)

* Translate setup/cri.md in Korean (kubernetes#12174)

* Translate setup/cri.md in Korean

* Apply review, Translate setup/cri.md in Korean

* Translate tasks/tools/install-minikube in Korean (kubernetes#12176)

* Translate tasks/tools/install-minikube in Korean

* Apply review,Trans tasks/tools/install-minikube in KO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gochist gochist gochist left review comments

@claudiajkang claudiajkang Awaiting requested review from claudiajkang

Assignees

@gochist gochist

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Swalloow @k8s-ci-robot @gochist