Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ko-trans: Translate node-conformance.md #11907

Merged

Conversation

dongjoon-hyun
Copy link

/language ko
/assign @gochist

@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 27, 2018
verification and functionality test for a node. The test validates whether the
node meets the minimum requirements for Kubernetes; a node that passes the test
is qualified to join a Kubernetes cluster.
*노드 적합성 테스트* 는 노드의 시스템 검증과 기능 테스트를 제공하기 위해 컨테이너화된 테스트 프레임워크이다.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*는이라고 붙여서 했더니, 휴고에서 이탤릭으로 변환이 되지않아서 부득히 * 는으로 변경했습니다. 변경 후 생성된 화면은 아래와 같습니다.

screen shot 2018-12-26 at 9 25 00 pm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다! 나중에 Hugo 쪽에 버그 리포트를 하는 것도 좋을 것 같습니다.

@dongjoon-hyun
Copy link
Author

안녕하세요. @gochist , @claudiajkang 님.
시간되실 때 리뷰해주실 수 있으신지요?

@dongjoon-hyun
Copy link
Author

감사합니다. @kychoolkim 님. 수정했습니다!

Copy link
Member

@gochist gochist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dongjoon-hyun 감사합니다! 리뷰가 늦어 죄송합니다. 몇 가지 리뷰 의견 드렸고, 참고를 요청드린 내용은 선택적으로 조치해주시면 되겠습니다.

verification and functionality test for a node. The test validates whether the
node meets the minimum requirements for Kubernetes; a node that passes the test
is qualified to join a Kubernetes cluster.
*노드 적합성 테스트* 는 노드의 시스템 검증과 기능 테스트를 제공하기 위해 컨테이너화된 테스트 프레임워크이다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다! 나중에 Hugo 쪽에 버그 리포트를 하는 것도 좋을 것 같습니다.

content/ko/docs/setup/node-conformance.md Outdated Show resolved Hide resolved
content/ko/docs/setup/node-conformance.md Outdated Show resolved Hide resolved
content/ko/docs/setup/node-conformance.md Outdated Show resolved Hide resolved
@dongjoon-hyun
Copy link
Author

감사합니다. 수정했습니다. @gochist

@gochist
Copy link
Member

gochist commented Jan 1, 2019

/lgtm
/approve
@dongjoon-hyun 감사합니다!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gochist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit 86d6038 into kubernetes:dev-1.13-ko.4 Jan 1, 2019
@dongjoon-hyun
Copy link
Author

승인 감사합니다.

@dongjoon-hyun dongjoon-hyun deleted the node-conformance branch January 1, 2019 04:09
k8s-ci-robot pushed a commit that referenced this pull request Jan 16, 2019
* ko-trans: Fix broken page index for concepts/overview (#11533)

* ko-trans: Update outdated files in dev-1.13-ko.4 (#11544)

* 1. Translate naturally (#11759)

2. Fix markdown error

* ko-trans: Translate building-from-source.md (#11893)

* ko-trans: Translate building-from-source.md

* Address comments

* Update etcd.md (#11976)

* ko-trans: Translate ko/_index.html into Korean (#11937)

* ko-trans: Translate ko/_index.html into Korean.

* Reflect a translation comment. Translate ko/_index.html into Korean

* ko-trans: Translate online-training/overview.md (#11932)

* ko-trans: Translate node-conformance.md (#11907)

* ko-trans: Translate node-conformance.md

* Replace 명세 with 매니페스트.

* Address comments

* ko-trans: Translate tutorials/configuration (#11933)

* ko-trans: Translate `tutorials/configuration` directory

* Address comments

* ko-trans: content/ko/docs/reference/glossary/controller.md (#11994)

* ko-trans: Controller

ko-trans: Controller

* the feedback applied.

the feedback applied.

* minor edit

minor edit

* minor edit #2

minor edit #2

* ko-trans: reference/glossary/kube-apiserver.md (#12024)

ko-trans: reference/glossary/kube-apiserver.md

* Translate tutorials/stateless-application/ in Korean (#12008)

* Translate tutorials/stateless-application/ in Korean

* Apply comments

* Fix deployment related typos

* Translate content/ko/docs/concepts/architecture/nodes in Korean #11748 (#11850)

* Translate content/ko/docs/concepts/architecture/nodes in Korean #11748

* Translate content/ko/docs/concepts/architecture/nodes in Korean #11748

* Translate content/ko/docs/concepts/architecture/nodes in Korean #11748

* Translate concepts/workloads/pods/pod-lifecycle in Korean (#12054)

* Translate concepts/workloads/pods/pod-lifecycle in Korean

* apply review ko-translate concepts/.../pod-lifecycle

* ko-trans: kube-controller-manager.md (#12077)

ko-trans: docs/reference/glossary/kube-controller-manager.md

* fix Italic syntax markdown error (#12128)

* Translate tasks/_index.md in Korean (#12126)

* Translate tasks/_index.md in Korean

* Apply review for Translate tasks/_index.md in Korean

Apply comments for Translate tasks/_index.md in Korean

* Translate setup/_index.md in Korean (#12067)

* Translate setup/_index.md in Korean

* Update setup/_index.md for Korean term consistency

* ko-trans: docs/setup/custom-cloud/kops.md (#11904)

* ko-trans: concepts/overview/working-with-objects/names (#11758)

* ko-trans: /docs/concepts/overview/working-with-objects/namespaces.md (#11773)

* Translate setup/cri.md in Korean (#12174)

* Translate setup/cri.md in Korean

* Apply review, Translate setup/cri.md in Korean

* Translate tasks/tools/install-minikube in Korean (#12176)

* Translate tasks/tools/install-minikube in Korean

* Apply review,Trans tasks/tools/install-minikube in KO
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Jan 29, 2019
* ko-trans: Fix broken page index for concepts/overview (kubernetes#11533)

* ko-trans: Update outdated files in dev-1.13-ko.4 (kubernetes#11544)

* 1. Translate naturally (kubernetes#11759)

2. Fix markdown error

* ko-trans: Translate building-from-source.md (kubernetes#11893)

* ko-trans: Translate building-from-source.md

* Address comments

* Update etcd.md (kubernetes#11976)

* ko-trans: Translate ko/_index.html into Korean (kubernetes#11937)

* ko-trans: Translate ko/_index.html into Korean.

* Reflect a translation comment. Translate ko/_index.html into Korean

* ko-trans: Translate online-training/overview.md (kubernetes#11932)

* ko-trans: Translate node-conformance.md (kubernetes#11907)

* ko-trans: Translate node-conformance.md

* Replace 명세 with 매니페스트.

* Address comments

* ko-trans: Translate tutorials/configuration (kubernetes#11933)

* ko-trans: Translate `tutorials/configuration` directory

* Address comments

* ko-trans: content/ko/docs/reference/glossary/controller.md (kubernetes#11994)

* ko-trans: Controller

ko-trans: Controller

* the feedback applied.

the feedback applied.

* minor edit

minor edit

* minor edit kubernetes#2

minor edit kubernetes#2

* ko-trans: reference/glossary/kube-apiserver.md (kubernetes#12024)

ko-trans: reference/glossary/kube-apiserver.md

* Translate tutorials/stateless-application/ in Korean (kubernetes#12008)

* Translate tutorials/stateless-application/ in Korean

* Apply comments

* Fix deployment related typos

* Translate content/ko/docs/concepts/architecture/nodes in Korean kubernetes#11748 (kubernetes#11850)

* Translate content/ko/docs/concepts/architecture/nodes in Korean kubernetes#11748

* Translate content/ko/docs/concepts/architecture/nodes in Korean kubernetes#11748

* Translate content/ko/docs/concepts/architecture/nodes in Korean kubernetes#11748

* Translate concepts/workloads/pods/pod-lifecycle in Korean (kubernetes#12054)

* Translate concepts/workloads/pods/pod-lifecycle in Korean

* apply review ko-translate concepts/.../pod-lifecycle

* ko-trans: kube-controller-manager.md (kubernetes#12077)

ko-trans: docs/reference/glossary/kube-controller-manager.md

* fix Italic syntax markdown error (kubernetes#12128)

* Translate tasks/_index.md in Korean (kubernetes#12126)

* Translate tasks/_index.md in Korean

* Apply review for Translate tasks/_index.md in Korean

Apply comments for Translate tasks/_index.md in Korean

* Translate setup/_index.md in Korean (kubernetes#12067)

* Translate setup/_index.md in Korean

* Update setup/_index.md for Korean term consistency

* ko-trans: docs/setup/custom-cloud/kops.md (kubernetes#11904)

* ko-trans: concepts/overview/working-with-objects/names (kubernetes#11758)

* ko-trans: /docs/concepts/overview/working-with-objects/namespaces.md (kubernetes#11773)

* Translate setup/cri.md in Korean (kubernetes#12174)

* Translate setup/cri.md in Korean

* Apply review, Translate setup/cri.md in Korean

* Translate tasks/tools/install-minikube in Korean (kubernetes#12176)

* Translate tasks/tools/install-minikube in Korean

* Apply review,Trans tasks/tools/install-minikube in KO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants