Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The fix clicks the error hyperlink that 'here' appears #10315

Merged
merged 2 commits into from
Sep 24, 2018

Conversation

xichengliudui
Copy link
Contributor

The fix clicks the error hyperlink that 'here' appears

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 17, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 17, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit c3d72e1

https://deploy-preview-10315--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Sep 17, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 9ecf281

https://deploy-preview-10315--kubernetes-io-master-staging.netlify.com

@xichengliudui
Copy link
Contributor Author

/approve cancel

@xichengliudui
Copy link
Contributor Author

/assign @bobsky

@Bradamant3
Copy link
Contributor

/assign @zacharysarah

@zacharysarah
Copy link
Contributor

@xichengliudui 👋 Thanks for opening this PR! Please take a look at #10087 and update this PR with the URL convention in #10087. Specifically, please replace:

release-1.10

with:

{{ <param “docsbranch”> }}

Thanks in advance!

The fix clicks the error hyperlink that 'here' appears

The fix clicks the error hyperlink that 'here' appears
@xichengliudui
Copy link
Contributor Author

@zacharysarah OK,Thanks

@zacharysarah
Copy link
Contributor

@xichengliudui 👋 I missed that this was an updated link to k/k, not k/website. Sorry! 🙇

It looks like the link you're updating has changed significantly, with its contents moved to a different repo. I've modified the entire link path here.

@zacharysarah
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2018
@k8s-ci-robot k8s-ci-robot merged commit 1cf4f53 into kubernetes:master Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants