Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retitle “Configuring kubelet Garbage Collection” and add incoming links #25300

Closed
sftim opened this issue Nov 29, 2020 · 7 comments · Fixed by #25457
Closed

Retitle “Configuring kubelet Garbage Collection” and add incoming links #25300

sftim opened this issue Nov 29, 2020 · 7 comments · Fixed by #25457
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@sftim
Copy link
Contributor

sftim commented Nov 29, 2020

This is a Bug Report

Problem:
Configuring kubelet Garbage Collection is a page about performing a particular task, but it lives in the Concepts section. Tasks should be in the tasks section.

Proposed Solution:

Page to Update:
https://kubernetes.io/docs/concepts/cluster-administration/kubelet-garbage-collection/

Additional Information:
/kind cleanup
/language en
/sig node
/help

Relevant to issue #4510

It is OK to clean up the content of the page beyond what this issue describes.

@k8s-ci-robot
Copy link
Contributor

@sftim:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

This is a Bug Report

Problem:
Configuring kubelet Garbage Collection is a page about performing a particular task, but it lives in the Concepts section. Tasks should be in the tasks section.

Proposed Solution:

(remember, this PR will just cover the English localization)

Page to Update:
https://kubernetes.io/docs/concepts/cluster-administration/kubelet-garbage-collection/

Additional Information:
/kind cleanup
/language en
/sig node
/help

Relevant to issue #4510

It is OK to clean up the content of the page beyond what this issue describes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/node Categorizes an issue or PR as relevant to SIG Node. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 29, 2020
@k8s-ci-robot
Copy link
Contributor

@sftim: This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tengqm
Copy link
Contributor

tengqm commented Nov 30, 2020

No. I don't agree to this movement. The reason is that garbage collection is an administrator job. However, https://kubernetes.io/docs/concepts/containers/ is mostly about concepts an end user need to know. If needed, we can add links to make sure users can learn what's happening behind the scene. Page movement like this is harmful rather than helpful.

@sftim
Copy link
Contributor Author

sftim commented Nov 30, 2020

@tengqm I've revised the issue description

/retitle Retitle “Configuring kubelet Garbage Collection” and add incoming links

@k8s-ci-robot k8s-ci-robot changed the title Move “Configuring kubelet Garbage Collection” into Containers section, with update Retitle “Configuring kubelet Garbage Collection” and add incoming links Nov 30, 2020
@Kartik494
Copy link
Contributor

/assign

@kbhawkey
Copy link
Contributor

To confirm, the goal of this issue is to:

  • retitle the GC concept page (not move the page or retitle the file)?
  • link from the containers concept page to the GC concept page

@kbhawkey
Copy link
Contributor

Note: I found 2 Garbage Collection concept pages:
https://kubernetes.io/docs/concepts/cluster-administration/kubelet-garbage-collection/
https://kubernetes.io/docs/concepts/workloads/controllers/garbage-collection/

The "cluster-administration" GC concept page focuses on the kubelet flags.
This page is not listed in the "cluster-administration" index page. Could the index page list the GC page under the "Managing a Cluster" section?
A side note, where is imageManager defined?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants