Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with k8s.io/docs/tasks/tools/install-minikube/ #22233

Closed
racheruk opened this issue Jul 1, 2020 · 6 comments
Closed

Issue with k8s.io/docs/tasks/tools/install-minikube/ #22233

racheruk opened this issue Jul 1, 2020 · 6 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@racheruk
Copy link

racheruk commented Jul 1, 2020

The install doc prescribe to use "sudo install minikube /usr/local/bin/" but it is not appropriate.

The commands are very prescriptive in the sense that i.e.

  1. download the binary
  2. make it executable using chmod
  3. create directory /usr/local/bin/
  4. use install command to "copy" the binary to /usr/local/bin/

Step 2 is not necessary

Proposed Solution:
Couple of options that are sensible

Option 1 :
Remove Step 2
Add Step 5 to delete downloaded file

Option 2 :
Step 4 : Please change "sudo install minikube /usr/local/bin/" to "sudo mv minikube /usr/local/bin/"

Page to Update:
https://kubernetes.io/docs/tasks/tools/install-minikube/

@prasadkatti
Copy link
Contributor

I think the command is valid. There is an install command that your machine may not have - https://linux.die.net/man/1/install

@racheruk
Copy link
Author

racheruk commented Jul 2, 2020

@prasadkatti Apologies for having very short description of the issue. Updated it to include more context.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 30, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 30, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants