Skip to content

Commit 065b96a

Browse files
committed
respond to feedback
1 parent 057abf2 commit 065b96a

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

docs/admin/admission-controllers.md

+11-10
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,7 @@ This admission controller defaults and limits what node selectors may be used wi
434434

435435
#### Configuration File Format
436436

437-
PodNodeSelector uses a configuration file to set options for the behavior of the backend.
437+
`PodNodeSelector` uses a configuration file to set options for the behavior of the backend.
438438
Note that the configuration file format will move to a versioned file in a future release.
439439
This file may be json or yaml and has the following format:
440440

@@ -445,7 +445,7 @@ podNodeSelectorPluginConfig:
445445
namespace2: <node-selectors-labels>
446446
```
447447

448-
Reference the PodNodeSelector configuration file from the file provided to the API server's command line flag `--admission-control-config-file`:
448+
Reference the `PodNodeSelector` configuration file from the file provided to the API server's command line flag `--admission-control-config-file`:
449449

450450
```yaml
451451
kind: AdmissionConfiguration
@@ -457,7 +457,7 @@ plugins:
457457
```
458458

459459
#### Configuration Annotation Format
460-
PodNodeSelector uses the annotation key `scheduler.kubernetes.io/node-selector` to assign node selectors to namespaces.
460+
`PodNodeSelector` uses the annotation key `scheduler.kubernetes.io/node-selector` to assign node selectors to namespaces.
461461

462462
```yaml
463463
apiVersion: v1
@@ -470,15 +470,16 @@ metadata:
470470

471471
#### Internal Behavior
472472
This admission controller has the following behavior:
473-
1. If the namespace has an annotation with a key `scheduler.kubernetes.io/nodeSelector`, use its value as the
474-
namespace node selector.
475-
2. If the namespace lacks such an annotation, use the `clusterDefaultNodeSelector` defined in the plugin
476-
configuration file as the namespace node selector.
477-
3. Evaluate the pod's node selector against the namespace node selector for conflicts. Conflicts result in rejection.
478-
4. Evaluate the pod's node selector against the namespace-specific whitelist defined the plugin configuration file.
473+
1. If the `Namespace` has an annotation with a key `scheduler.kubernetes.io/nodeSelector`, use its value as the
474+
node selector.
475+
1. If the namespace lacks such an annotation, use the `clusterDefaultNodeSelector` defined in the `PodNodeSelector`
476+
plugin configuration file as the node selector.
477+
1. Evaluate the pod's node selector against the namespace node selector for conflicts. Conflicts result in rejection.
478+
1. Evaluate the pod's node selector against the namespace-specific whitelist defined the plugin configuration file.
479479
Conflicts result in rejection.
480480

481-
Note: PodTolerationRestriction is more versatile and powerful than PodNodeSelector and can encompass the scenarios supported by PodNodeSelector.
481+
**Note:** `PodTolerationRestriction` is more versatile and powerful than `PodNodeSelector` and can encompass the scenarios supported by `PodNodeSelector`.
482+
{: .note}
482483

483484
### PersistentVolumeClaimResize
484485

0 commit comments

Comments
 (0)