Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: add kinder test jobs for k8s 1.20 #19852

Merged
merged 1 commit into from
Dec 2, 2020
Merged

kubeadm: add kinder test jobs for k8s 1.20 #19852

merged 1 commit into from
Dec 2, 2020

Conversation

RA489
Copy link
Contributor

@RA489 RA489 commented Nov 5, 2020

for the kubeadm PR to merge first:
kubernetes/kubeadm#2337

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 5, 2020
@RA489
Copy link
Contributor Author

RA489 commented Nov 5, 2020

/hold

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Nov 5, 2020
@RA489
Copy link
Contributor Author

RA489 commented Nov 5, 2020

/assign @neolit123

@RA489 RA489 mentioned this pull request Nov 5, 2020
Merged
@RA489
Copy link
Contributor Author

RA489 commented Nov 5, 2020

/test pull-test-infra-bazel

@neolit123
Copy link
Member

hm, looks like the release 1.20 dashboards are not created yet:
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/test-infra/19852/pull-test-infra-bazel/1324311666434772992

annotations: couldn't find dashboard "sig-release-1.20-informing" for job "ci-kubernetes-e2e-kubeadm-kinder-1-20"

we should wait for that first. i asked the question in #release-ci-signal on slack.

@neolit123
Copy link
Member

@RA489 we are going to have to keep this PR on hold until 1 December when the branch will be created:

https://kubernetes.slack.com/archives/CN0K3TE2C/p1604587020178500

https://github.com/kubernetes/sig-release/tree/master/releases/release-1.20
code freeze: Thu November 12
branch creation: Tue December 1

without the release-1.20 branch these jobs will fail.

@neolit123 neolit123 mentioned this pull request Nov 5, 2020
Closed
7 tasks
@RA489
Copy link
Contributor Author

RA489 commented Nov 30, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2020
@RA489
Copy link
Contributor Author

RA489 commented Dec 1, 2020 •
edited
Loading

@RA489 we are going to have to keep this PR on hold until 1 December when the branch will be created:

https://kubernetes.slack.com/archives/CN0K3TE2C/p1604587020178500

https://github.com/kubernetes/sig-release/tree/master/releases/release-1.20
code freeze: Thu November 12
branch creation: Tue December 1

without the release-1.20 branch these jobs will fail.

@neolit123 ready for LGTM

@justaugustus
Copy link
Member

justaugustus commented Dec 1, 2020 •
edited
Loading

without the release-1.20 branch these jobs will fail.

This is NOT ready for approval, as the release-1.20 branch does not exist yet.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2020
@neolit123
Copy link
Member

ok, the branch was created today:
https://github.com/kubernetes/kubernetes/tree/release-1.20

once we have the sig-release-1.20-informing dashboard this PR can merge too:
https://k8s-testgrid.appspot.com/sig-release-master-informing

@justaugustus
Copy link
Member

Watch this PR: #20079
I'm working on the branch job creation + dashboard updates there.

@neolit123
Copy link
Member

/retest

@RA489
Copy link
Contributor Author

RA489 commented Dec 2, 2020

I hope release-1.20 branch is created and we can remove hold on this PR.

@neolit123
Copy link
Member

please change all old and new instances of the string v20201031-122dc79 to be v20201201-1941b8f in all the files

we should also update the old images, but i will send a separate PR for that.
thank you for helping with this task!

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, RA489

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1bfb2ee into kubernetes:master Dec 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Dec 2, 2020
@k8s-ci-robot
Copy link
Contributor

@RA489: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubeadm-kinder-discovery.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-discovery.yaml
  • key kubeadm-kinder-external-etcd.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-external-etcd.yaml
  • key kubeadm-kinder-upgrade.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-upgrade.yaml
  • key kubeadm-kinder-x-on-y.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-x-on-y.yaml
  • key kubeadm-kinder.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder.yaml

In response to this:

for the kubeadm PR to merge first:
kubernetes/kubeadm#2337

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
4 participants
@RA489 @neolit123 @justaugustus @k8s-ci-robot