-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubernetes-csi: split up jobs into unit/alpha/non-alpha #12088
Conversation
resources: | ||
requests: | ||
cpu: 2000m | ||
- name: pull-kubernetes-csi-csi-driver-host-path-alpha-1-13-on-kubernetes-master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alpha suites should not run cross versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess for an alpha pull job, we should only have master->master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alpha suites should not run cross versions.
They can for known configurations (like 1.13 on 1.14), because for those we can configure which tests are expected to work. But if we don't want that, we can also leave those alpha tests optional.
For all -on-kubernetes-master
jobs the intention was to never make these tests mandatory pre-submit checks, because there's no guarantee that this check doesn't get broken by changes in master, see
test-infra/config/jobs/kubernetes-csi/gen-jobs.sh
Lines 204 to 206 in 04c6ebf
# Experimental job, explicitly needs to be started with /test. | |
# This cannot be enabled by default because there's always the risk | |
# that something changes in master which breaks the pre-merge check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should encourage providing more alpha support than our policy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt that many people besides the core team will know that these jobs are possible, so I'm not sure who or what that would encourage. But I don't have a strong opinion about those, so I can also take them out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Also fixed some settings for the canary jobs.
This is meant to help developers who look at tests results understand more quickly what the root cause of a failure might be because they don't need to look at the individual test name. Splitting up the pre-merge jobs also speeds up providing feedback on a PR, because jobs complete faster. Naming of jobs is a bit more consistent now, with "kubernetes-csi" being used also for pre-merge jobs. csi-driver-host-path now has: pull-kubernetes-csi-csi-driver-host-path-1-13-on-kubernetes-1-13 pull-kubernetes-csi-csi-driver-host-path-1-13-on-kubernetes-master pull-kubernetes-csi-csi-driver-host-path-1-14-on-kubernetes-1-14 pull-kubernetes-csi-csi-driver-host-path-1-14-on-kubernetes-master pull-kubernetes-csi-csi-driver-host-path-alpha-1-13-on-kubernetes-1-13 (*) pull-kubernetes-csi-csi-driver-host-path-alpha-1-14-on-kubernetes-1-14 (*) pull-kubernetes-csi-csi-driver-host-path-unit (*) ci-kubernetes-csi-1-13-on-kubernetes-1-13 ci-kubernetes-csi-1-13-on-kubernetes-1-14 ci-kubernetes-csi-1-13-on-kubernetes-master ci-kubernetes-csi-alpha-1-13-on-kubernetes-1-13 (*) ci-kubernetes-csi-canary-on-kubernetes-1-13 ci-kubernetes-csi-canary-on-kubernetes-1-14 ci-kubernetes-csi-canary-on-kubernetes-master ci-kubernetes-csi-alpha-canary-on-kubernetes-master (*) Jobs marked (*) with are new, other others have been changed to not run alpha tests. The "liveness-probe" pre-merge tests were limited to run only on one Kubernetes version because there is no real dependency on Kubernetes APIs.
The jobs still used pohly/csi-driver-host-path instead of kubernetes-csi/csi-driver-host-path.
04c6ebf
to
5376d7b
Compare
They have to specify the full version because that is how we find the pre-built KinD image.
/lgtm |
LGTM label has been added. Git tree hash: b6f73bb421c38d5e6fd42ae2139ef0d6717d5f3d
|
/assign @michelle192837 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michelle192837, msau42, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pohly: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is meant to help developers who look at tests results understand
more quickly what the root cause of a failure might be because they
don't need to look at the individual test name.
Splitting up the pre-merge jobs also speeds up providing feedback on a
PR, because jobs complete faster.
Naming of jobs is a bit more consistent now, with "kubernetes-csi"
being used also for pre-merge jobs. csi-driver-host-path
now has:
Jobs marked (*) with are new, other others have been changed to not
run alpha tests.
The "liveness-probe" pre-merge tests were limited to run only on one
Kubernetes version because there is no real dependency on Kubernetes
APIs.