Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prow doesn't automatically apply language labels #10097

Closed
1 of 2 tasks
zacharysarah opened this issue Nov 8, 2018 · 3 comments
Closed
1 of 2 tasks

Prow doesn't automatically apply language labels #10097

zacharysarah opened this issue Nov 8, 2018 · 3 comments
Assignees
Labels
area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/docs Categorizes an issue or PR as relevant to SIG Docs.

Comments

@zacharysarah
Copy link

zacharysarah commented Nov 8, 2018

This is a...

  • Feature Request
  • Bug Report

Problem

Prow doesn't automatically assign language labels to PRs in k/website.

Per @cblecker in kubernetes/website#10485 (comment):

Based on what I understand you're doing, you could add this label section to the language-specific OWNERS files you're already creating to delegate approval permissions, and prow would label those PRs natively. No external application required!

Using the example provided as a template, we added OWNERS files to each language subfolder:

Subsequently, Prow has not applied any language labels to PRs with content changes in the relevant directories. For example:

Proposed solution

  1. Provide guidance.

Should we be doing something differently? If we're doing something incorrectly, it's non-obvious to us.

2a. Fix Prow.

👍

2b. Decline to fix Prow.

We'll re-enable the kubernetes-docs-language-labeler.

/area prow
/sig docs
/kind bug
/priority important-soon

/assign @cblecker @spiffxp

@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow sig/docs Categorizes an issue or PR as relevant to SIG Docs. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 8, 2018
@BenTheElder
Copy link
Member

First off, you write wonderful, detailed issues, thank you. 😄

It looks like the owners-label plugin is not enabled for kubernetes/website:

https://prow.k8s.io/plugins (look for owners-labels, click "details" for more info)
https://prow.k8s.io/plugins?repo=kubernetes%2Fwebsite (the plugin is not in the list for this repo)

I will PR a fix.

/assign

@zacharysarah
Copy link
Author

Fixed by #10099

@cblecker
Copy link
Member

cblecker commented Nov 8, 2018

Thanks @BenTheElder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow Issues or PRs related to prow kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/docs Categorizes an issue or PR as relevant to SIG Docs.
Projects
None yet
Development

No branches or pull requests

5 participants