-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TestSkaffold to use unique profile names, more debuggable #9064
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
kvm2 Driver Times for Minikube (PR 9064): 57.0s 64.9s 62.6s Averages Time Per Log
docker Driver Times for Minikube (PR 9064): 25.8s 27.1s 26.8s Averages Time Per Log
|
kvm2 Driver Times for Minikube (PR 9064): 62.6s 61.8s 64.3s Averages Time Per Log
docker Driver Times for Minikube (PR 9064): 26.8s 25.5s 26.6s Averages Time Per Log
|
While investigating a flake - I made some adjustments to TestSkaffold:
Here was the flake:
https://storage.googleapis.com/minikube-builds/logs/9050/f5c3a82/Docker_Linux.html#fail_TestSkaffold
Three things I noticed while debugging:
registry-server
OOM, but this test doesn't enable the registryminikube
tominikube
The first two issues ppear to be related to tests reusing the same profile name.
I've updated this test to use the secret
--minikube-profile
flag to Skaffold to workaround the hard-coded "minikube" cluster requirement. In the next Skaffold release, we should be able to drop this flag.