Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TestSkaffold to use unique profile names, more debuggable #9064

Merged
merged 3 commits into from
Aug 24, 2020

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Aug 22, 2020

While investigating a flake - I made some adjustments to TestSkaffold:

Here was the flake:

https://storage.googleapis.com/minikube-builds/logs/9050/f5c3a82/Docker_Linux.html#fail_TestSkaffold

Three things I noticed while debugging:

  • The registry-serverOOM, but this test doesn't enable the registry
  • Docker cert mismatches
  • The test failed locally because it copied minikube to minikube

The first two issues ppear to be related to tests reusing the same profile name.

I've updated this test to use the secret --minikube-profile flag to Skaffold to workaround the hard-coded "minikube" cluster requirement. In the next Skaffold release, we should be able to drop this flag.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 22, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 22, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 61.9s 61.2s 62.3s
Average time for minikube: 61.8s

Times for Minikube (PR 9064): 57.0s 64.9s 62.6s
Average time for Minikube (PR 9064): 61.5s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9064) |
+--------------------------------+----------+--------------------+
| * minikube v1.12.3 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.2s    | 38.4s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.18.3 | 20.0s    | 20.8s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.2s     | 1.4s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.2s     | 0.7s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
| * Done! kubectl is now         | 0.1s     | 0.1s               |
| configured to use "minikube"   |          |                    |
|                                | 0.0s     | 0.0s               |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 26.1s 26.2s 27.3s
Average time for minikube: 26.5s

Times for Minikube (PR 9064): 25.8s 27.1s 26.8s
Average time for Minikube (PR 9064): 26.6s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9064) |
+--------------------------------+----------+--------------------+
| * minikube v1.12.3 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.1s     | 0.1s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 8.7s     | 8.6s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.18.3 | 16.6s    | 16.8s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 0.9s     | 0.9s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.0s     | 0.1s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
| * Done! kubectl is now         | 0.1s     | 0.1s               |
| configured to use "minikube"   |          |                    |
|                                | 0.0s     | 0.0s               |
+--------------------------------+----------+--------------------+

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: 65.1s 63.5s 61.3s
Average time for minikube: 63.3s

Times for Minikube (PR 9064): 62.6s 61.8s 64.3s
Average time for Minikube (PR 9064): 62.9s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9064) |
+--------------------------------+----------+--------------------+
| * minikube v1.12.3 on Debian   | 0.2s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.1s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.4s    | 40.1s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.18.3 | 21.0s    | 21.3s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.3s     | 1.4s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.2s     | 0.0s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
| * Done! kubectl is now         | 0.1s     | 0.1s               |
| configured to use "minikube"   |          |                    |
|                                | 0.0s     | 0.0s               |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 27.1s 27.1s 25.3s
Average time for minikube: 26.5s

Times for Minikube (PR 9064): 26.8s 25.5s 26.6s
Average time for Minikube (PR 9064): 26.3s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9064) |
+--------------------------------+----------+--------------------+
| * minikube v1.12.3 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.1s     | 0.1s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 8.7s     | 8.5s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.18.3 | 16.5s    | 16.6s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 0.9s     | 0.9s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.0s     | 0.1s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
| * Done! kubectl is now         | 0.1s     | 0.1s               |
| configured to use "minikube"   |          |                    |
|                                | 0.0s     | 0.0s               |
+--------------------------------+----------+--------------------+

@tstromberg tstromberg merged commit 2b44c59 into kubernetes:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants