Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to use internal containerd for docker #8518

Merged
merged 4 commits into from
Jun 23, 2020
Merged

Make sure to use internal containerd for docker #8518

merged 4 commits into from
Jun 23, 2020

Conversation

afbjorklund
Copy link
Collaborator

When not using the containerd.service, we should make
sure that dockerd does not use the stopped containerd.

Closes #8203

@afbjorklund
Make sure to use internal containerd for docker
f2ea21a 
When not using the containerd.service, we should make
sure that dockerd does not use the stopped containerd.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2020
@afbjorklund
Copy link
Collaborator Author

Here was the sequence being used:

Run: sudo systemctl cat docker.service
Run: sudo systemctl is-active --quiet service containerd
Run: sudo systemctl stop -f containerd
Run: sudo systemctl is-active --quiet service containerd
Run: sudo systemctl is-active --quiet service crio
Run: sudo systemctl stop -f crio
Run: sudo systemctl is-active --quiet service crio
Run: sudo systemctl daemon-reload
Run: sudo systemctl start docker

When starting up dockerd with containerd running, it must be restarted (not started) after stopping containerd.

Otherwise it will still be using /run/containerd/containerd.sock instead of /run/docker/containerd/containerd.sock

Error while dialing dial unix:///run/containerd/containerd.sock

Only do this when not configured to use the containerd.socket.

The new sequence will instead be:

Run: sudo systemctl cat docker.service
Run: sudo systemctl is-active --quiet service containerd
Run: sudo systemctl stop -f containerd
Run: sudo systemctl is-active --quiet service containerd
Run: sudo systemctl is-active --quiet service crio
Run: sudo systemctl stop -f crio
Run: sudo systemctl is-active --quiet service crio
Run: sudo systemctl cat docker.service
Run: sudo systemctl daemon-reload
Run: sudo systemctl restart docker

@TravisBuddy
Copy link

Travis tests have failed

Hey @afbjorklund,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test 
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.13.8.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.13.8.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.12.0-beta.0 -X k8s.io/minikube/pkg/version.isoVersion=v1.11.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="fdc2c6f09ab78b34eb9ff6722b758ebb26a9884a"" ./test.sh
= schema_check ==========================================================
go: downloading github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: extracting github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: extracting github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
go: extracting github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
go: finding github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: finding github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: finding github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
ok
= go test ===============================================================
go: downloading github.com/machine-drivers/machine v0.7.1-0.20200323212942-41eb826190d8
go: downloading github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: downloading github.com/spf13/cobra v1.0.0
go: downloading github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: extracting github.com/spf13/cobra v1.0.0
go: downloading github.com/shirou/gopsutil v2.18.12+incompatible
go: extracting github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: extracting github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: extracting github.com/shirou/gopsutil v2.18.12+incompatible
go: downloading k8s.io/apimachinery v0.17.3
go: extracting github.com/machine-drivers/machine v0.7.1-0.20200323212942-41eb826190d8
go: downloading github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: downloading github.com/otiai10/copy v1.0.2
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: downloading github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading github.com/sayboras/dockerclient v0.0.0-20191231050035-015626177a97
go: downloading github.com/spf13/pflag v1.0.5
go: extracting github.com/sayboras/dockerclient v0.0.0-20191231050035-015626177a97
go: extracting k8s.io/apimachinery v0.17.3
go: extracting github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: extracting github.com/otiai10/copy v1.0.2
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: extracting github.com/pkg/errors v0.9.1
go: downloading github.com/afbjorklund/go-containerregistry v0.0.0-20200602203322-347d93793dc9
go: extracting github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading k8s.io/client-go v0.17.3
go: extracting github.com/spf13/pflag v1.0.5
go: extracting github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: extracting github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: downloading github.com/olekukonko/tablewriter v0.0.4
go: extracting github.com/olekukonko/tablewriter v0.0.4
go: extracting github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading github.com/blang/semver v3.5.0+incompatible
go: extracting github.com/blang/semver v3.5.0+incompatible
go: downloading golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: downloading gopkg.in/yaml.v2 v2.3.0
go: extracting golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: downloading golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: extracting gopkg.in/yaml.v2 v2.3.0
go: extracting github.com/afbjorklund/go-containerregistry v0.0.0-20200602203322-347d93793dc9
go: extracting golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: extracting k8s.io/client-go v0.17.3
go: downloading github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: downloading github.com/spf13/viper v1.7.0
go: downloading github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: extracting github.com/spf13/viper v1.7.0
go: downloading github.com/hashicorp/hcl v1.0.0
go: extracting github.com/hashicorp/hcl v1.0.0
go: extracting github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: downloading k8s.io/api v0.17.3
go: downloading github.com/spf13/afero v1.2.2
go: extracting github.com/spf13/afero v1.2.2
go: downloading github.com/gogo/protobuf v1.3.1
go: downloading github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: downloading github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: downloading k8s.io/klog v1.0.0
go: extracting github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: downloading golang.org/x/text v0.3.2
go: extracting k8s.io/klog v1.0.0
go: extracting github.com/gogo/protobuf v1.3.1
go: extracting github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: extracting k8s.io/api v0.17.3
go: extracting github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: downloading github.com/cheggaaa/pb v1.0.27
go: extracting github.com/cheggaaa/pb v1.0.27
go: downloading github.com/cheggaaa/pb/v3 v3.0.1
go: extracting github.com/cheggaaa/pb/v3 v3.0.1
go: downloading github.com/libvirt/libvirt-go v3.4.0+incompatible
go: downloading github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: downloading github.com/spf13/cast v1.3.1
go: extracting github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: extracting github.com/spf13/cast v1.3.1
go: downloading golang.org/x/sys v0.0.0-20200523222454-059865788121
go: extracting github.com/libvirt/libvirt-go v3.4.0+incompatible
go: downloading github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: downloading cloud.google.com/go v0.57.0
go: downloading github.com/magiconair/properties v1.8.1
go: downloading github.com/mattn/go-colorable v0.1.6
go: downloading github.com/cpuguy83/go-md2man v1.0.10
go: extracting github.com/magiconair/properties v1.8.1
go: downloading github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: downloading github.com/subosito/gotenv v1.2.0
go: downloading k8s.io/kubernetes v1.17.3
go: extracting github.com/mattn/go-colorable v0.1.6
go: downloading github.com/mattn/go-isatty v0.0.12
go: extracting github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: downloading github.com/mattn/go-runewidth v0.0.7
go: extracting github.com/subosito/gotenv v1.2.0
go: downloading github.com/docker/go-connections v0.4.0
go: extracting golang.org/x/text v0.3.2
go: extracting github.com/mattn/go-isatty v0.0.12
go: downloading github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: extracting github.com/mattn/go-runewidth v0.0.7
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: extracting github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: downloading github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: extracting github.com/docker/go-connections v0.4.0
go: downloading k8s.io/utils v0.0.0-20200229041039-0a110f9eb7ab
go: extracting github.com/cpuguy83/go-md2man v1.0.10
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0
go: extracting github.com/cpuguy83/go-md2man/v2 v2.0.0
go: extracting golang.org/x/sys v0.0.0-20200523222454-059865788121
go: extracting cloud.google.com/go v0.57.0
go: extracting github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: extracting k8s.io/utils v0.0.0-20200229041039-0a110f9eb7ab
go: downloading github.com/google/gofuzz v1.0.0
go: extracting github.com/docker/distribution v2.7.1+incompatible
go: extracting github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: downloading google.golang.org/api v0.25.0
go: downloading github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: extracting github.com/google/gofuzz v1.0.0
go: downloading github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: downloading cloud.google.com/go/storage v1.8.0
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: extracting k8s.io/kubernetes v1.17.3
go: extracting github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: extracting github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: downloading github.com/aws/aws-sdk-go v1.31.6
go: downloading github.com/mitchellh/go-testing-interface v1.0.0
go: downloading github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: downloading github.com/ulikunitz/xz v0.5.7
go: extracting github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading github.com/golang/protobuf v1.4.2
go: extracting cloud.google.com/go/storage v1.8.0
go: downloading github.com/modern-go/reflect2 v1.0.1
go: extracting github.com/spf13/jwalterweatherman v1.1.0
go: downloading google.golang.org/grpc v1.29.1
go: extracting github.com/ulikunitz/xz v0.5.7
go: extracting github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: downloading google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: extracting github.com/mitchellh/go-testing-interface v1.0.0
go: downloading github.com/imdario/mergo v0.3.9
go: extracting github.com/russross/blackfriday/v2 v2.0.1
go: downloading golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: downloading sigs.k8s.io/yaml v1.1.0
go: extracting google.golang.org/api v0.25.0
go: extracting github.com/modern-go/reflect2 v1.0.1
go: extracting github.com/golang/protobuf v1.4.2
go: downloading github.com/googleapis/gnostic v0.3.0
go: downloading k8s.io/cluster-bootstrap v0.17.3
go: extracting github.com/aws/aws-sdk-go v1.31.6
go: extracting golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: extracting google.golang.org/grpc v1.29.1
go: extracting sigs.k8s.io/yaml v1.1.0
go: downloading github.com/json-iterator/go v1.1.8
go: extracting github.com/imdario/mergo v0.3.9
go: downloading k8s.io/kubectl v0.17.3
go: extracting k8s.io/cluster-bootstrap v0.17.3
go: extracting github.com/googleapis/gnostic v0.3.0
go: downloading github.com/hashicorp/go-version v1.2.0
go: downloading google.golang.org/protobuf v1.24.0
go: downloading github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: downloading k8s.io/component-base v0.17.3
go: extracting github.com/json-iterator/go v1.1.8
go: downloading golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: extracting google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: downloading github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: extracting github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: extracting github.com/hashicorp/go-version v1.2.0
go: downloading github.com/mitchellh/mapstructure v1.3.1
go: extracting google.golang.org/protobuf v1.24.0
go: extracting k8s.io/kubectl v0.17.3
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: downloading github.com/hashicorp/go-safetemp v1.0.0
go: downloading github.com/opencontainers/image-spec v1.0.1
go: downloading k8s.io/kubelet v0.17.3
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: extracting github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: extracting k8s.io/component-base v0.17.3
go: extracting github.com/hashicorp/go-cleanhttp v0.5.1
go: extracting golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: extracting github.com/shurcooL/sanitized_anchor_name v1.0.0
go: downloading github.com/docker/go-units v0.4.0
go: downloading github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: downloading github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: downloading github.com/VividCortex/ewma v1.1.1
go: downloading github.com/fatih/color v1.9.0
go: extracting github.com/hashicorp/go-safetemp v1.0.0
go: extracting github.com/mitchellh/mapstructure v1.3.1
go: downloading github.com/jmespath/go-jmespath v0.3.0
go: extracting k8s.io/kubelet v0.17.3
go: downloading k8s.io/kube-proxy v0.17.3
go: extracting github.com/opencontainers/image-spec v1.0.1
go: extracting sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading github.com/prometheus/client_golang v1.1.0
go: downloading github.com/miekg/dns v1.1.4
go: extracting github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: extracting github.com/docker/go-units v0.4.0
go: downloading github.com/google/go-cmp v0.4.1
go: downloading github.com/docker/docker-credential-helpers v0.6.3
go: extracting github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: extracting github.com/fatih/color v1.9.0
go: downloading github.com/pelletier/go-toml v1.8.0
go: extracting github.com/VividCortex/ewma v1.1.1
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: extracting github.com/jmespath/go-jmespath v0.3.0
go: extracting github.com/miekg/dns v1.1.4
go: extracting k8s.io/kube-proxy v0.17.3
go: extracting github.com/prometheus/client_golang v1.1.0
go: extracting golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading github.com/sirupsen/logrus v1.6.0
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading go.opencensus.io v0.22.3
go: downloading github.com/google/uuid v1.1.1
go: extracting github.com/pelletier/go-toml v1.8.0
go: extracting github.com/google/go-cmp v0.4.1
go: extracting github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: extracting github.com/docker/docker-credential-helpers v0.6.3
go: extracting github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/mitchellh/go-wordwrap v1.0.0
go: downloading github.com/fsnotify/fsnotify v1.4.9
go: downloading github.com/hashicorp/golang-lru v0.5.3
go: downloading github.com/prometheus/common v0.6.0
go: extracting github.com/google/uuid v1.1.1
go: extracting github.com/sirupsen/logrus v1.6.0
go: extracting github.com/mitchellh/go-homedir v1.1.0
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading k8s.io/kube-openapi v0.0.0-20191107075043-30be4d16710a
go: extracting go.opencensus.io v0.22.3
go: extracting github.com/fsnotify/fsnotify v1.4.9
go: extracting github.com/hashicorp/golang-lru v0.5.3
go: extracting github.com/mitchellh/go-wordwrap v1.0.0
go: downloading github.com/prometheus/client_model v0.0.0-20190812154241-14fe0d1b01d4
go: downloading github.com/googleapis/gax-go v2.0.2+incompatible
go: extracting github.com/prometheus/common v0.6.0
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading github.com/prometheus/procfs v0.0.5
go: extracting github.com/googleapis/gax-go v2.0.2+incompatible
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: extracting gopkg.in/inf.v0 v0.9.1
go: extracting github.com/prometheus/client_model v0.0.0-20190812154241-14fe0d1b01d4
go: downloading github.com/beorn7/perks v1.0.1
go: extracting github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading gopkg.in/ini.v1 v1.56.0
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: extracting github.com/prometheus/procfs v0.0.5
go: extracting github.com/googleapis/gax-go/v2 v2.0.5
go: extracting github.com/beorn7/perks v1.0.1
go: extracting github.com/davecgh/go-spew v1.1.1
go: extracting github.com/matttproud/golang_protobuf_extensions v1.0.1
go: extracting github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: extracting gopkg.in/ini.v1 v1.56.0
go: extracting k8s.io/kube-openapi v0.0.0-20191107075043-30be4d16710a
go: finding github.com/machine-drivers/machine v0.7.1-0.20200323212942-41eb826190d8
go: finding github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: finding github.com/pkg/errors v0.9.1
go: finding github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: finding github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: finding github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: finding github.com/docker/go-units v0.4.0
go: finding github.com/spf13/cobra v1.0.0
go: finding github.com/olekukonko/tablewriter v0.0.4
go: finding github.com/blang/semver v3.5.0+incompatible
go: finding k8s.io/client-go v0.17.3
go: finding github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: finding github.com/libvirt/libvirt-go v3.4.0+incompatible
go: finding github.com/spf13/viper v1.7.0
go: finding golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: finding github.com/mattn/go-runewidth v0.0.7
go: finding github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: finding github.com/imdario/mergo v0.3.9
go: finding k8s.io/api v0.17.3
go: finding github.com/spf13/pflag v1.0.5
go: finding github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: finding k8s.io/apimachinery v0.17.3
go: finding github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: finding golang.org/x/sys v0.0.0-20200523222454-059865788121
go: finding github.com/mattn/go-isatty v0.0.12
go: finding github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: finding github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: finding github.com/afbjorklund/go-containerregistry v0.0.0-20200602203322-347d93793dc9
go: finding github.com/gogo/protobuf v1.3.1
go: finding github.com/google/uuid v1.1.1
go: finding github.com/fsnotify/fsnotify v1.4.9
go: finding github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: finding github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: finding github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: finding github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: finding github.com/hashicorp/hcl v1.0.0
go: finding github.com/shirou/gopsutil v2.18.12+incompatible
go: finding github.com/magiconair/properties v1.8.1
go: finding github.com/google/gofuzz v1.0.0
go: finding cloud.google.com/go/storage v1.8.0
go: finding github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: finding github.com/mitchellh/mapstructure v1.3.1
go: finding sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: finding k8s.io/klog v1.0.0
go: finding golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: finding github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: finding github.com/pelletier/go-toml v1.8.0
go: finding github.com/otiai10/copy v1.0.2
go: finding github.com/cpuguy83/go-md2man/v2 v2.0.0
go: finding github.com/cenkalti/backoff v2.2.1+incompatible
go: finding github.com/docker/docker-credential-helpers v0.6.3
go: finding github.com/golang/protobuf v1.4.2
go: finding golang.org/x/text v0.3.2
go: finding cloud.google.com/go v0.57.0
go: finding github.com/spf13/afero v1.2.2
go: finding gopkg.in/inf.v0 v0.9.1
go: finding github.com/docker/distribution v2.7.1+incompatible
go: finding github.com/googleapis/gnostic v0.3.0
go: finding github.com/spf13/cast v1.3.1
go: finding golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: finding github.com/prometheus/client_golang v1.1.0
go: finding github.com/russross/blackfriday/v2 v2.0.1
go: finding github.com/spf13/jwalterweatherman v1.1.0
go: finding gopkg.in/yaml.v2 v2.3.0
go: finding k8s.io/kubernetes v1.17.3
go: finding github.com/googleapis/gax-go/v2 v2.0.5
go: finding github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: finding golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: finding github.com/cheggaaa/pb/v3 v3.0.1
go: finding google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: finding github.com/subosito/gotenv v1.2.0
go: finding github.com/opencontainers/go-digest v1.0.0-rc1
go: finding google.golang.org/api v0.25.0
go: finding google.golang.org/grpc v1.29.1
go: finding gopkg.in/ini.v1 v1.56.0
go: finding github.com/shurcooL/sanitized_anchor_name v1.0.0
go: finding google.golang.org/protobuf v1.24.0
go: finding go.opencensus.io v0.22.3
go: finding github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: finding k8s.io/kubectl v0.17.3
go: finding github.com/VividCortex/ewma v1.1.1
go: finding k8s.io/component-base v0.17.3
go: finding github.com/json-iterator/go v1.1.8
go: finding github.com/beorn7/perks v1.0.1
go: finding github.com/docker/go-connections v0.4.0
go: finding github.com/modern-go/reflect2 v1.0.1
go: finding github.com/fatih/color v1.9.0
go: finding github.com/prometheus/client_model v0.0.0-20190812154241-14fe0d1b01d4
go: finding github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: finding github.com/mattn/go-colorable v0.1.6
go: finding github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: finding github.com/prometheus/common v0.6.0
go: finding github.com/opencontainers/image-spec v1.0.1
go: finding github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: finding github.com/sayboras/dockerclient v0.0.0-20191231050035-015626177a97
go: finding github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: finding golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: finding github.com/davecgh/go-spew v1.1.1
go: finding github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: finding github.com/prometheus/procfs v0.0.5
go: finding k8s.io/cluster-bootstrap v0.17.3
go: finding github.com/sirupsen/logrus v1.6.0
go: finding github.com/matttproud/golang_protobuf_extensions v1.0.1
go: finding sigs.k8s.io/yaml v1.1.0
go: finding k8s.io/utils v0.0.0-20200229041039-0a110f9eb7ab
go: finding github.com/mitchellh/go-wordwrap v1.0.0
go: finding github.com/aws/aws-sdk-go v1.31.6
go: finding k8s.io/kube-proxy v0.17.3
go: finding k8s.io/kubelet v0.17.3
go: finding github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: finding github.com/miekg/dns v1.1.4
go: finding github.com/hashicorp/go-cleanhttp v0.5.1
go: finding github.com/hashicorp/go-safetemp v1.0.0
go: finding github.com/hashicorp/go-version v1.2.0
go: finding github.com/mitchellh/go-homedir v1.1.0
go: finding github.com/hashicorp/golang-lru v0.5.3
go: finding github.com/mitchellh/go-testing-interface v1.0.0
go: finding github.com/ulikunitz/xz v0.5.7
go: finding github.com/google/go-cmp v0.4.1
go: finding k8s.io/kube-openapi v0.0.0-20191107075043-30be4d16710a
go: finding github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: finding github.com/jmespath/go-jmespath v0.3.0
go: finding github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading github.com/evanphx/json-patch v4.5.0+incompatible
go: downloading golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
go: downloading github.com/pmezard/go-difflib v1.0.0
go: extracting github.com/pmezard/go-difflib v1.0.0
go: extracting github.com/evanphx/json-patch v4.5.0+incompatible
go: extracting golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
go: finding github.com/pmezard/go-difflib v1.0.0
go: finding golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
go: finding github.com/evanphx/json-patch v4.5.0+incompatible
ok  	k8s.io/minikube/cmd/minikube/cmd	3.740s	coverage: 20.4% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.164s	coverage: 21.5% of statements
ok  	k8s.io/minikube/pkg/addons	0.071s	coverage: 57.3% of statements
ok  	k8s.io/minikube/pkg/drivers	0.015s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/hyperkit	0.002s	coverage: 77.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.035s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	0.879s	coverage: 55.7% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil	0.103s	coverage: 63.2% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil/ktmpl	0.032s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/images	0.025s	coverage: 88.9% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.100s	coverage: 16.8% of statements
ok  	k8s.io/minikube/pkg/minikube/command	0.015s	coverage: 4.3% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.174s	coverage: 67.3% of statements
--- FAIL: TestEnable (0.00s)
    --- FAIL: TestEnable/docker (0.00s)
        cruntime_test.go:194: bin=sudo args=[systemctl cat docker.service]
        cruntime_test.go:194: bin=sudo args=[systemctl is-active --quiet service containerd]
        cruntime_test.go:476: fake systemctl: containerd is-status: 0
        cruntime_test.go:194: bin=sudo args=[systemctl is-active --quiet service crio]
        cruntime_test.go:476: fake systemctl: crio is-status: 0
        cruntime_test.go:194: bin=sudo args=[systemctl cat docker.service]
        cruntime_test.go:194: bin=sudo args=[systemctl daemon-reload]
        cruntime_test.go:194: bin=sudo args=[systemctl restart docker]
        cruntime_test.go:474: fake systemctl: SvcRestarted docker
        cruntime_test.go:598: service diff (-want +got):
              map[string]cruntime.serviceState{
              	"containerd":    0,
              	"crio":          0,
              	"crio-shutdown": 0,
            - 	"docker":        1,
            + 	"docker":        2,
              }
args 4: [ps -a --quiet --name=apiserver]
args 4: [ps -a --quiet --name=apiserver]
args 3: [ps -a --quiet]
args 3: [ps -a --quiet]
args 4: [ps -a --quiet --name=apiserver]
args 4: [ps -a --quiet --name=apiserver]
args 3: [ps -a --quiet]
args 3: [ps -a --quiet]
FAIL
coverage: 40.6% of statements
FAIL	k8s.io/minikube/pkg/minikube/cruntime	0.053s
ok  	k8s.io/minikube/pkg/minikube/docker	0.031s	coverage: 20.8% of statements
ok  	k8s.io/minikube/pkg/minikube/driver	0.019s	coverage: 37.1% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.012s	coverage: 58.8% of statements
ok  	k8s.io/minikube/pkg/minikube/image	0.028s	coverage: 3.0% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.026s	coverage: 77.0% of statements
ok  	k8s.io/minikube/pkg/minikube/localpath	0.010s	coverage: 51.9% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.053s	coverage: 1.3% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	1.408s	coverage: 37.8% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.013s	coverage: 92.9% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.039s	coverage: 67.4% of statements
ok  	k8s.io/minikube/pkg/minikube/perf	4.196s	coverage: 33.8% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.011s	coverage: 91.7% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.007s	coverage: 77.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.007s	coverage: 75.5% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.057s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/shell	0.016s	coverage: 96.9% of statements
ok  	k8s.io/minikube/pkg/minikube/storageclass	0.015s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/sysinit	0.021s	coverage: 6.5% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.003s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.608s	coverage: 64.2% of statements
ok  	k8s.io/minikube/pkg/util	0.739s	coverage: 77.9% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.007s	coverage: 18.2% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.006s	coverage: 0.0% of statements
FAIL
Makefile:273: recipe for target 'test' failed
make: *** [test] Error 32
TravisBuddy Request Identifier: 699602a0-b2cd-11ea-894e-97d5968798bd

@afbjorklund
Copy link
Collaborator Author

It would be possible to "optimize" this, by looking to see if the containerd was Active before it was Disabled.
If it (containerd) was stopped before dockerd was started, then the internal daemon would have been used.

But it is not worth the special case, and there some edge-cases (really need to be looking at what it uses)
And it's kinda stupid anyway, so the way to really optimize is to only start the services that are needed/wanted.

At least this way it doesn't just hang at boot, even if it might (?) take 10 seconds or so longer.

When docker.service is changed to used containerd.service instead, it will not have to restart.

@afbjorklund
Adjust unit test results when docker not bound
22e1a41 
When docker.service is *not* bound to containerd.service,
that means that it will be restarted to not try to use it.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 20, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #8518 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8518   +/-   ##
=======================================
  Coverage   33.87%   33.88%           
=======================================
  Files         154      154           
  Lines        9897     9899    +2     
=======================================
+ Hits         3353     3354    +1     
- Misses       6140     6141    +1     
  Partials      404      404
Impacted Files Coverage Δ
pkg/minikube/cruntime/docker.go 27.50% <100.00%> (+0.22%) ⬆️

@medyagh
Copy link
Member

medyagh commented Jun 22, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 22, 2020
@kubernetes kubernetes deleted a comment from minikube-pr-bot Jun 22, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [63.558258226 65.15038715500002 62.967820696]
Average time for minikube: 63.89215535899999

Times for Minikube (PR 8518): [64.939720759 67.19685330700001 64.375637303]
Average time for Minikube (PR 8518): 65.50407045633332

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8518) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.0-beta.0 on   |  0.059918 |           0.056190 |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.020422 |           0.018958 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.008190 |           0.003015 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.368067 |          42.195941 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 21.559588 |          21.303047 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.502614 |           1.592809 |
| components...                  |           |                    |
| * Enabled addons:              |  0.298316 |           0.257470 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.071268 |           0.071194 |
| configured to use "minikube"   |           |                    |
|                                |  0.003772 |           0.005446 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.902184297999998 36.621003347999995 26.695455226999997]
Average time for minikube: 30.406214290999998

Times for Minikube (PR 8518): [27.909823907000003 25.399893089000003 26.574547641]
Average time for Minikube (PR 8518): 26.628088212333335

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8518) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.12.0-beta.0 on           |  0.075698 |           0.074271 |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002485 |           0.002561 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.058244 |           0.059937 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.676281 |           7.652529 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.3         |  0.123003 |           0.123953 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 18.642387 |          17.760492 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  3.544142 |           0.770955 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.217922 |           0.112974 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.061667 |           0.063086 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004386 |           0.007331 |
+----------------------------------------+-----------+--------------------+

@medyagh
Copy link
Member

medyagh commented Jun 22, 2020 •
edited
Loading

All three non kic drivers tests failed, KVM, Virtualbox, Hyperkit fail on TestPause/serial/SecondStartNoReconfiguration

the relevent error message is

I0622 12:46:06.833727   19291 kubeadm.go:467] needs reconfigure: apiserver in state Stopped

which means these two commands
minikube start
minikube start

will cause api server to be stopped.

KVM:
https://storage.googleapis.com/minikube-builds/logs/8518/22e1a41/KVM_Linux.html#fail_TestPause%2fserial%2fSecondStartNoReconfiguration

Virtualbox:
https://storage.googleapis.com/minikube-builds/logs/8518/22e1a41/VirtualBox_Linux.html#fail_TestPause%2fserial%2fSecondStartNoReconfiguration

Hyperkit:
https://storage.googleapis.com/minikube-builds/logs/8518/22e1a41/HyperKit_macOS.html#fail_TestPause%2fserial%2fSecondStartNoReconfiguration

could it be side effect of this PR that restarts docker but the apisever container stopped and not restarted?

@afbjorklund
Only restart dockerd if containerd was running
e25ab78 
If starting minikube a second time, do nothing.
@afbjorklund
Add test case restarting docker after containerd
4027ba4 
If we stopped containerd, we restart dockerd.
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 23, 2020
@afbjorklund
Copy link
Collaborator Author

It was stopping due to the docker restart, now there should only be one restart (the first time) so should be fixed. Added a unit test.

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [62.09331552 63.148906943 65.47528870300002]
Average time for minikube: 63.572503722000015

Times for Minikube (PR 8518): [64.0628594 63.93488335399999 65.375345129]
Average time for Minikube (PR 8518): 64.457695961

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8518) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.0-beta.0 on   |  0.060222 |           0.057812 |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.020292 |           0.040838 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.011002 |           0.003202 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.116784 |          40.602994 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 21.928424 |          21.874878 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.227318 |           1.190442 |
| components...                  |           |                    |
| * Enabled addons:              |  0.126956 |           0.603754 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.078216 |           0.079771 |
| configured to use "minikube"   |           |                    |
|                                |  0.003289 |           0.004005 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [26.931704660000005 27.240921369000002 36.884814172]
Average time for minikube: 30.352480067000002

Times for Minikube (PR 8518): [26.057575515000003 26.272541984000004 25.391872984000003]
Average time for Minikube (PR 8518): 25.907330161000004

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8518) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.12.0-beta.0 on           |  0.070322 |           0.071229 |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002589 |           0.002654 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.057972 |           0.059191 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.620089 |           7.828290 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.3         |  0.115757 |           0.117276 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 18.740270 |          16.875589 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  3.459662 |           0.759666 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.211947 |           0.123658 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.068670 |           0.064230 |
| configured to use "minikube"           |           |                    |
|                                        |  0.005203 |           0.005546 |
+----------------------------------------+-----------+--------------------+

@medyagh medyagh merged commit 4f6a9f6 into kubernetes:master Jun 23, 2020
@afbjorklund afbjorklund mentioned this pull request Jul 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

@tstromberg tstromberg Awaiting requested review from tstromberg

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race condition between dockerd and containerd
6 participants
@afbjorklund @k8s-ci-robot @TravisBuddy @codecov-commenter @medyagh @minikube-pr-bot