Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run 'minikube logs' when sub-tests fail, remove some extraneous logging #8051

Merged
merged 4 commits into from
May 11, 2020
Merged

Run 'minikube logs' when sub-tests fail, remove some extraneous logging #8051

merged 4 commits into from
May 11, 2020

Conversation

tstromberg
Copy link
Contributor

This is my attempt to make integration tests more relevant:

  • Sub-tests which mutate state should now show post-mortem logs at the completion of the sub-test. Which means we will now show logs closer to the point of failure.

  • Post-mortem logs now include "minikube logs" and "docker inspect". I removed "docker logs" and "df", since they aren't as useful. I also removed other logs which are duplicated by "minikube logs".

  • Post-mortem logs now describe only the pods which are not running, which reduces the amount of unimportant information.

  • Reduce verbosity for tests where it hasn't been useful. The added verbosity here was just including libmachine logs.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 8, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 8, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [66.010136245 66.20861576299998 65.107885244]
Average time for minikube: 65.77554575066665

Times for Minikube (PR 8051): [65.620839079 65.342391438 67.151121313]
Average time for Minikube (PR 8051): 66.03811727666667

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8051) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on   |  0.061406 |           0.065991 |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.020959 |           0.024717 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.008474 |           0.003778 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.876941 |          40.914368 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.1 | 22.582720 |          22.785653 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.538375 |           1.419482 |
| components...                  |           |                    |
| * Enabled addons:              |  0.596810 |           0.733870 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.084837 |           0.084008 |
| configured to use "minikube"   |           |                    |
|                                |  0.005023 |           0.006249 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [26.463213808000006 25.318781506 27.483183235999995]
Average time for minikube: 26.421726183333334

Times for Minikube (PR 8051): [27.19383085799999 29.298809534 26.837276436]
Average time for Minikube (PR 8051): 27.776638942666665

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8051) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on           |  0.073199 |           0.077136 |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002479 |           0.002909 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.060513 |           0.059677 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.767019 |           7.498776 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.1         |  0.119549 |           0.120788 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.308644 |          18.452741 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.851188 |           1.491133 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.173031 |           0.002745 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.062412 |           0.067268 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003694 |           0.003466 |
+----------------------------------------+-----------+--------------------+

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 8, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @tstromberg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 3beab2a0-918b-11ea-9e78-458f7b3d5a30

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [66.644474267 68.61592016700001 66.882671913]
Average time for minikube: 67.38102211566667

Times for Minikube (PR 8051): [62.79598678700001 65.541904657 61.791106934]
Average time for Minikube (PR 8051): 63.376332792666666

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8051) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on   |  0.061906 |           0.063052 |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.021948 |           0.021395 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003298 |           0.003232 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 42.089543 |          39.749601 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.1 | 22.810098 |          21.382863 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.495503 |           1.783355 |
| components...                  |           |                    |
| * Enabled addons:              |  0.806020 |           0.290601 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.087911 |           0.077697 |
| configured to use "minikube"   |           |                    |
|                                |  0.004795 |           0.004536 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [26.966281769999995 27.777191326 25.703216936]
Average time for minikube: 26.815563343999997

Times for Minikube (PR 8051): [27.188582207999996 27.285879382000005 26.952988401000002]
Average time for Minikube (PR 8051): 27.142483330333334

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8051) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on           |  0.075247 |           0.079435 |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002598 |           0.002444 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.061387 |           0.059652 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.854310 |           7.771954 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.1         |  0.122935 |           0.121915 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.567600 |          17.768466 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.885725 |           1.188418 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.171341 |           0.078680 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.069013 |           0.066548 |
| configured to use "minikube"           |           |                    |
|                                        |  0.005408 |           0.004972 |
+----------------------------------------+-----------+--------------------+

@codecov-io
Copy link

Codecov Report

Merging #8051 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8051   +/-   ##
=======================================
  Coverage   35.45%   35.45%           
=======================================
  Files         146      146           
  Lines        9284     9284           
=======================================
  Hits         3292     3292           
  Misses       5592     5592           
  Partials      400      400

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [65.114209857 65.551952328 64.139361103]
Average time for minikube: 64.93517442933333

Times for Minikube (PR 8051): [61.489142438 65.277431346 65.178181208]
Average time for Minikube (PR 8051): 63.981584997333336

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8051) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on   |  0.062835 |           0.061732 |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.022150 |           0.019917 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.002990 |           0.002826 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.623457 |          39.720995 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.1 | 22.185298 |          21.790747 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.457318 |           1.422892 |
| components...                  |           |                    |
| * Enabled addons:              |  0.498282 |           0.865415 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.079826 |           0.091269 |
| configured to use "minikube"   |           |                    |
|                                |  0.003019 |           0.005791 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [26.126802785 27.034821262999994 24.53090678]
Average time for minikube: 25.897510276000002

Times for Minikube (PR 8051): [26.806373284000003 27.469437271 27.491883757999997]
Average time for Minikube (PR 8051): 27.255898104333337

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8051) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.2 on           |  0.074964 |           0.078821 |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002834 |           0.002431 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.058281 |           0.061185 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.554844 |           7.555908 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.1         |  0.119925 |           0.144497 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.033743 |          18.170874 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.897748 |           1.106756 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.085411 |           0.061868 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.065099 |           0.068826 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004662 |           0.004732 |
+----------------------------------------+-----------+--------------------+

@tstromberg tstromberg merged commit acd2ae1 into kubernetes:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tstromberg @k8s-ci-robot @minikube-pr-bot @TravisBuddy @codecov-io @medyagh