Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: change wait for cni #7486

Merged
merged 2 commits into from
Apr 7, 2020
Merged

CI: change wait for cni #7486

merged 2 commits into from
Apr 7, 2020

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Apr 7, 2020

minikube with CNI has always had this issue #7354
and we still needs to fix it.
but the new --wait feature can not be used with this test

this should make the tests green again.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 7, 2020
@medyagh medyagh changed the title wait cni CI: change wait for cni Apr 7, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020
@medyagh
Copy link
Member Author

medyagh commented Apr 7, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 7, 2020
@medyagh medyagh requested a review from tstromberg April 7, 2020 18:13
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@minikube-pr-bot
Copy link

All Times minikube: [ 65.937067 65.747304 66.198421]
All Times Minikube (PR 7486): [ 68.441048 62.786449 66.707125]

Average minikube: 65.960931
Average Minikube (PR 7486): 65.978207

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7486) |
+----------------------+-----------+--------------------+
| minikube v           |  0.232771 |           0.228179 |
| Creating kvm2        | 40.396392 |          41.095561 |
| Preparing Kubernetes | 23.305148 |          22.370318 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

@sharifelgamal
Copy link
Collaborator

The unit test failure seems to be the standard SSH flake, we should look into that again.

@medyagh medyagh merged commit 0a2bc95 into kubernetes:master Apr 7, 2020
@medyagh medyagh deleted the cni_wait branch May 2, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants