Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

none: stop kube-system containers on startup to avoid interference #6519

Closed
wants to merge 1 commit into from

Conversation

tstromberg
Copy link
Contributor

Hopefully fixes none driver flakes.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@tstromberg tstromberg closed this Feb 6, 2020
@codecov-io
Copy link

Codecov Report

Merging #6519 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6519      +/-   ##
==========================================
- Coverage   37.95%   37.95%   -0.01%     
==========================================
  Files         138      138              
  Lines        8707     8708       +1     
==========================================
  Hits         3305     3305              
- Misses       4985     4986       +1     
  Partials      417      417
Impacted Files Coverage Δ
pkg/addons/addons.go 45.67% <0%> (-0.29%) ⬇️
pkg/minikube/cluster/start.go 52.33% <0%> (ø) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants