Sorts the outputs and also prints out alternative driver info when no driver is picked.

[lxzhang000]

fixes #10009

Looks like "Unhealthy" prioriy level is now only used for driver selection, and I think it is not necessary since we can get the unhealthy info to filter the driver out from State.Healthy.

Another problem associated with this one is that the current alternatives is not printed out when failed.

Before:

1. All rejects are in "Unhealthy" priority therefore can't not be displayed by preference.
2. No info of alternative drivers that are not picked.

After:

1. All rejects keeps their orginal priority.
2. The alternative drivers lower than "Discouraged" priority will also be printed out (take "ssh" as an example).

* Unable to pick a default driver. Here is what was considered, in preference order:
  ...
  - ssh: Rejected due to low priority
  ...

[k8s-ci-robot]

Hi @lxzhang000. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lxzhang000
To complete the pull request process, please assign sharifelgamal after the PR has been reviewed.
You can assign the PR to them by writing /assign @sharifelgamal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

@lxzhang000 please check unit test

run make test locally

[medyagh]

I can not verify if this PR is brekaing a logic that @tstromberg intended or not (classifiying an unhealthy driver as a priority of its own)

I refer judgment to @tstromberg

[tstromberg]

Overall, things seem right to me. Tested using:

touch /tmp/podman && chmod 755 /tmp/podman && env PATH=/tmp ./out/minikube start

Output:

😄  minikube v1.17.1 on Debian rodete
👎  Unable to pick a default driver. Here is what was considered, in preference order:
    ▪ docker: Not installed: exec: "docker": executable file not found in $PATH
    ▪ kvm2: Not installed: exec: "virsh": executable file not found in $PATH
    ▪ vmware: Not installed: exec: "docker-machine-driver-vmware": executable file not found in $PATH
    ▪ virtualbox: Not installed: unable to find VBoxManage in $PATH
    ▪ ssh: Rejected due to low priority
    ▪ none: Not installed: exec: "iptables": executable file not found in $PATH
    ▪ podman: Not healthy: exec: "sudo": executable file not found in $PATH

❌  Exiting due to DRV_NOT_DETECTED: No possible driver was detected. Try specifying --driver, or see https://minikube.sigs.k8s.io/docs/start/

The only request is to improve the "Rejected due to low priority" text.

[afbjorklund]

For podman it is true that it is still experimental, but hope to change that for next release. It should be on par with Docker.

See #10237

[lxzhang000]

Hi, @medyagh I have updated the failed unit tests. FYI, I could pass the uni test locally even before the modification and the reason is that if two drivers have the same priority, their order is not determined.

I suppose the root cause is the traversal order of go map is not determinded:

minikube/pkg/minikube/registry/registry.go

Line 158 in 47da1ff

for _, def := range r.drivers {

Looks like for display it doesn't care the order if drivers have the same priority, I use different priorites for unit test.

[k8s-ci-robot]

@lxzhang000: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.