Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEP: Standard Linux Distribution ("distro") #10067

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

afbjorklund
Copy link
Collaborator

See #9992

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 30, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2020
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you think this the right way to do, we could approve this and work on it for Q1 2021.
should we have a transition period where people who really love our Buildroot ISO keep using it ?

@afbjorklund
Copy link
Collaborator Author

should we have a transition period where people who really love our Buildroot ISO keep using it ?

Indeed, the plan was to have multiple ISO files (one being the default) - and use URL to select the other

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, priyawadhwa, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,priyawadhwa,tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one i think I liket his MEP to conver is the upgrade plan,

it seems to me the previous versions of minikube will not be able to upgrade to newer verison of minikube if we change the ISO's OS.
and they would need to do selete and start a new one.

if that this the case, we need to discuss it and possibliy roll out minikube 2 which will not support upgrading old versions.

this would mean minikube would have to add a mechanisim to detect old iso and and warn user to delete and start again.

@afbjorklund
Copy link
Collaborator Author

We have changed iso before, when we went from boot2docker to buildroot...
As long as the files on the /var disk image are compatible, it should be doable.

It's also not a blocker, even if it should require users to delete their cluster ?
I think we need a prototype, before we can tell if an upgrade is posssible or not

@tstromberg
Copy link
Contributor

tstromberg commented Jan 15, 2021 via email

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Jan 15, 2021

Before we look into making it a "general" distribution, we need something for the upgrade path.
Not saying that this is the only way, but it was one of the options (keep the distro, but external)

I was going to look into A/B booting, like this: https://source.android.com/devices/tech/ota/ab
Basically you have two installations, one active and one passive (where you do the upgrade)

Alternative to using a package manager.


This would be similar to minikube rebooting with a new ISO, but slightly more hard disk-centric.
Both require that you also have a third image, where you store the data that you want to keep.

I also had a fourth* image, that was used for pulling the images from (like the preload tarball)
This allows upgrading the container storage, if needed. But mostly used for the first installation.

And a fifth image for /data, but anyway.

@afbjorklund
Copy link
Collaborator Author

Agreed. In the past it hasn't been necessary to ask users to delete their
old VM's. Given how few entry points minikube actually has into the
built-in userland, I don't foresee compatibility issues.

I also wanted to make some drastic changes to the userland, like excluding the runtimes.

#9989

@tstromberg tstromberg merged commit cb72cdb into kubernetes:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants