Update README.md with usage and known issues. #100
Conversation
|
Be aware that you have two sections that explains nearly the same thing: https://github.com/dlorenc/minikube/blob/readme/README.md#usage; that's running Consider merging them or something |
|
I think that the usage, features, and known issues section are good. As @luxas mentioned though, we should probably try to keep the Usage and Run Instructions section consistent regarding using: minikube OR ./out/minikube start. Or we could perhaps merge them as I don't think the 'kubectl config' commands and without them the Run Instructions section is very similar to the Usage section. |
|
Thanks for the review. I reorganized it a bit so the ./out/minikube is only mentioned in the development instructions, the "usage" section is now meant for end users who will have minikube on their path. |
| Kubernetes is available at https://192.168.99.100:443. | ||
|
|
||
| $ $(minikube docker-env) | ||
| $ docker build -t helloworld . |
There was a problem hiding this comment.
As a user, I would wonder what this is... Is it a built-in thing or is it some required step or is it just a demo... and how may I try that demo out in that case...
There was a problem hiding this comment.
Clarified above that this is just a demo, and added a link to the tutorial.
dlorenc
force-pushed
the
readme
branch
2 times, most recently
from
c0fda77
to
031e607
Compare
|
LGTM |
You can see the README.md here: https://github.com/dlorenc/minikube/tree/readme