Verify Apiserver in docker-env

[medyagh]

currently we only wait 5 seconds after restarting,,,we should verify

here is an example of failure
https://storage.googleapis.com/minikube-builds/logs/9933/f3be305/Docker_Linux.html#fail_TestFunctional%2fparallel%2fDockerEnv

some places in the code

https://github.com/medyagh/minikube/blob/12893a6121d39ae4c3d2f2f7b4d9cfb3fa9f605f/cmd/minikube/cmd/docker-env.go#L245

https://github.com/medyagh/minikube/blob/12893a6121d39ae4c3d2f2f7b4d9cfb3fa9f605f/pkg/provision/ubuntu.go

[azhao155]

/assign azhao155

[prezha]

@azhao155 i was looking at #9936 where the TestFunctional/parallel/ComponentHealth fails because of expected component "kube-apiserver" was not found error (https://github.com/kubernetes/minikube/runs/1540063530#step:7:140), and, as @medyagh rightly pointed out, that should not happen as TestFunctional/serial/StartWithProxy was run before it with --wait=true flag set (that should ensure, amongst others, the apiserver was started):

minikube/test/integration/functional_test.go

Line 85 in a60e264

{"StartWithProxy", validateStartWithProxy}, // Set everything else up for success

minikube/test/integration/functional_test.go

Line 225 in a60e264

startArgs := append([]string{"start", "-p", profile, "--memory=4000", fmt.Sprintf("--apiserver-port=%d", apiPortTest), "--wait=true"}, StartArgs()...)

minikube/cmd/minikube/cmd/start_flags.go

Lines 665 to 667 in a60e264

	if waitFlags[0] == "true" || waitFlags[0] == "all" {
	klog.Infof("Waiting for all components: %+v", kverify.AllComponents)
	return kverify.AllComponents

minikube/pkg/minikube/bootstrapper/bsutil/kverify/kverify.go

Line 49 in a60e264

AllComponents = map[string]bool{APIServerWaitKey: true, SystemPodsWaitKey: true, DefaultSAWaitKey: true, AppsRunningKey: true, KubeletKey: true}

minikube/pkg/minikube/bootstrapper/bsutil/kverify/kverify.go

Line 29 in a60e264

APIServerWaitKey = "apiserver"

minikube/test/integration/functional_test.go

Line 114 in a60e264

{"ComponentHealth", validateComponentHealth},

so, these two issues might be related

[afbjorklund]

I don't understand the title, docker-env doesn't have anything to do wtih apiserver ?

[azhao155]

While run docker-env, we need to make sure dockerd is up. If it's not up, we need to wait for api server container to be up and then restart dockerd

[azhao155]

#9973 for the improvement.