Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more descriptive error codes for PROVIDER_DOCKER_ERROR #9908

Closed
nelango opened this issue Dec 10, 2020 · 2 comments · Fixed by #10212
Closed

Provide more descriptive error codes for PROVIDER_DOCKER_ERROR #9908

nelango opened this issue Dec 10, 2020 · 2 comments · Fixed by #10212
Labels
area/error-management Management of known errors kind/feature Categorizes issue or PR as related to a new feature. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Milestone

Comments

@nelango
Copy link

nelango commented Dec 10, 2020

PROVIDER_DOCKER_ERROR serves as a catch-all error for docker. Can minikube provide more descriptive error codes for docker related failures (besides docker not installed and docker not running which already have corresponding error codes)?

@tstromberg
Copy link
Contributor

It can - but as this happens for any unexpected Docker exit, making this more specific so will need analysis of the error text that goes alongside it.

@tstromberg
Copy link
Contributor

As a catchall error code, In order to break this code down further, we'll need to collect example error messages for known issues. We can then add support for them here:

https://github.com/kubernetes/minikube/blob/master/pkg/minikube/reason/known_issues.go

Unfortunately, we do not have any example error messages to go by. For instance, no one has opened an issue that mentions this error code:

https://github.com/kubernetes/minikube/issues?q=is%3Aissue+PROVIDER_DOCKER_ERROR

Until we have example error messages, we can't do much with this request, unfortunately.

@tstromberg tstromberg added kind/feature Categorizes issue or PR as related to a new feature. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Dec 14, 2020
@tstromberg tstromberg added this to the v1.17.0-candidate milestone Jan 7, 2021
@tstromberg tstromberg added the area/error-management Management of known errors label Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/error-management Management of known errors kind/feature Categorizes issue or PR as related to a new feature. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants