Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SHA image for addons #9884

Closed
medyagh opened this issue Dec 8, 2020 · 1 comment · Fixed by #10527
Closed

add SHA image for addons #9884

medyagh opened this issue Dec 8, 2020 · 1 comment · Fixed by #10527
Assignees
@medyagh
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v1.18.0

Comments

@medyagh
Copy link
Member

medyagh commented Dec 8, 2020 •
edited
Loading

for more security so if someone pushes the same image tag , we should not accept it, and we should secure it by adding the sha to the image tag

minikube/deploy/addons/registry-creds/registry-creds-rc.yaml.tmpl

Line 21 in 83f9bd1

- image: {{default "upmcenterprises" .ImageRepository}}/registry-creds:1.10

Current tag is pointing at upmcenterprises/registry-creds:1.10@sha256:93a633d4f2b76a1c66bf19c664dbddc56093a543de6d54320f19f585ccd7d605
@medyagh medyagh added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 8, 2020
@medyagh medyagh added this to the v1.18.0 milestone Feb 10, 2021
@jiefenghe
Copy link
Contributor

/assign

@jiefenghe jiefenghe removed their assignment Feb 11, 2021
@medyagh medyagh assigned jiefenghe and medyagh and unassigned jiefenghe Feb 16, 2021
@medyagh medyagh changed the title add SHA image for registry-creds add SHA image for addons Feb 20, 2021
@medyagh medyagh mentioned this issue Feb 20, 2021
Merged
@kadel kadel mentioned this issue Mar 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@medyagh medyagh

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v1.18.0
Development

Successfully merging a pull request may close this issue.

Ensure addon integrity by adding sha256 checksums to images medyagh/minikube
2 participants
@medyagh @jiefenghe