Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation error in every minikube command since 1.15.0 #9704

Closed
galishmann opened this issue Nov 14, 2020 · 7 comments · Fixed by #9715
Closed

Translation error in every minikube command since 1.15.0 #9704

galishmann opened this issue Nov 14, 2020 · 7 comments · Fixed by #9715
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@galishmann
Copy link

galishmann commented Nov 14, 2020

When I am trying to execute any command in minikube I have error message:

~ $ minikube version
I1114 13:59:47.843637   11252 translate.go:89] Failed to load translation file for en: Asset translations/en.json not found
minikube version: v1.15.0
commit: 3e098ff146b8502f597849dfda420a2fa4fa43f0
@afbjorklund
Copy link
Collaborator

afbjorklund commented Nov 14, 2020

Works here, which platform and locale are you on ? (it is not supposed to load a translation file for en)

@afbjorklund afbjorklund added kind/bug Categorizes issue or PR as related to a bug. triage/needs-information Indicates an issue needs more information in order to work on it. labels Nov 14, 2020
@afbjorklund
Copy link
Collaborator

afbjorklund commented Nov 14, 2020

Hmm, can reproduce with non-american locale:

$ LC_ALL=en_US.UTF-8 ./out/minikube version
minikube version: v1.15.0
commit: 3e098ff146b8502f597849dfda420a2fa4fa43f0
$ LC_ALL=en_GB.UTF-8 ./out/minikube version
I1114 14:50:45.479064  444106 translate.go:89] Failed to load translation file for en: Asset translations/en.json not found
minikube version: v1.15.0
commit: 3e098ff146b8502f597849dfda420a2fa4fa43f0

Or for other languages:

$ LC_ALL=sv_SE.UTF-8 ./out/minikube version
I1114 14:52:27.157482  444194 translate.go:89] Failed to load translation file for sv: Asset translations/sv.json not found
minikube version: v1.15.0
commit: 3e098ff146b8502f597849dfda420a2fa4fa43f

Worked OK in v1.14.2.

@afbjorklund afbjorklund added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed triage/needs-information Indicates an issue needs more information in order to work on it. labels Nov 14, 2020
@afbjorklund
Copy link
Collaborator

afbjorklund commented Nov 14, 2020

No changes to translate itself, though. So it looks like a klog change.

The error was there before as well, just didn't log it out to the console.

@fnichol
Copy link

fnichol commented Nov 14, 2020

I can confirm this behavior with the 1.15.0 release (running macOS 10.15.7).

Explicitly setting an en_US locale:

$ env LC_ALL=en_US.UTF-8 minikube version
minikube version: v1.15.0
commit: 3e098ff146b8502f597849dfda420a2fa4fa43f0

Setting a non-US locale--mine in this case:

$ env LC_ALL=en_CA.UTF-8 minikube version
I1114 13:07:25.983227   66526 translate.go:89] Failed to load translation file for en: Asset translations/en.json not found
minikube version: v1.15.0
commit: 3e098ff146b8502f597849dfda420a2fa4fa43f0

No locale environment variable set, presumably falling back to a variant of en_CA in my case:

$ env -u LC_ALL minikube version
I1114 13:06:48.939471   66485 translate.go:89] Failed to load translation file for en: Asset translations/en.json not found
minikube version: v1.15.0
commit: 3e098ff146b8502f597849dfda420a2fa4fa43f0

As always, I appreciate everyone's hard work on minikube! ❤️

@afbjorklund
Copy link
Collaborator

Before, we had these two lines in the minikube log:

translate.go:107] Setting Language to en-GB ...
translate.go:89] Failed to load translation file for en: Asset translations/en.json not found

Now the first line is gone, the other is on the console:

  • Points to 20a1274
  • Reverting this fixes it

@afbjorklund
Copy link
Collaborator

The error message is extra useless, since it doesn't actually look at that path (adding the file doesn't help)

So it only looks at the files that have been compiled into minikube the binary, and are available as an Asset

@sharifelgamal
Copy link
Collaborator

This is fixed in v1.15.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants