Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include JSON Output as a standard option. #9258

Closed
j-windsor opened this issue Sep 15, 2020 · 4 comments · Fixed by #9576
Closed

Include JSON Output as a standard option. #9258

j-windsor opened this issue Sep 15, 2020 · 4 comments · Fixed by #9576
Assignees
@priyawadhwa
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. ux/embedded Embedded UX blockers
Milestone
v1.15.0

Comments

@j-windsor
Copy link

the --output flag does not seem to be offered with most of the commands. start has it, but pause, unpause, and stop do not.

Is it possible to make this flag available to all commands as an inherited option? or at least more commands?
@sharifelgamal sharifelgamal added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 15, 2020
@sharifelgamal
Copy link
Collaborator

Yeah, I imagine this is the end goal for json output, but it's still a work in progress.

cc @priyawadhwa

@priyawadhwa
Copy link

Hey @j-windsor I think this would definitely be useful to include for the stop command. Both pause and unpause take <1 second to execute, and we initially added JSON output so that users could see progress during long-running commands. Do you think it would still make sense to add it in for pause and unpause as well?

@sharifelgamal sharifelgamal added the priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. label Sep 16, 2020
@tstromberg tstromberg added the ux/embedded Embedded UX blockers label Sep 17, 2020
@j-windsor
Copy link
Author

I think it would help. In Cloud Code VSCode we are trying to report the ErrorID in metrics and we are currently parsing the ID out of the "Exiting due to..." string.

@priyawadhwa priyawadhwa mentioned this issue Oct 28, 2020
Merged
@priyawadhwa
Copy link

Currently working on this now.

@priyawadhwa priyawadhwa self-assigned this Oct 28, 2020
@priyawadhwa priyawadhwa added this to the v1.15.0 milestone Oct 28, 2020
@priyawadhwa priyawadhwa added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@priyawadhwa priyawadhwa

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. ux/embedded Embedded UX blockers
Projects
None yet
Milestone
v1.15.0
Development

Successfully merging a pull request may close this issue.

Add JSON output to stop, pause and unpause priyawadhwa/minikube
4 participants
@tstromberg @j-windsor @priyawadhwa @sharifelgamal