Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve message, when there is profile name other than "minikube" #9247

Closed
medyagh opened this issue Sep 14, 2020 · 5 comments · Fixed by #9613
Closed

improve message, when there is profile name other than "minikube" #9247

medyagh opened this issue Sep 14, 2020 · 5 comments · Fixed by #9613
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@medyagh
Copy link
Member

medyagh commented Sep 14, 2020

I only have one cluster, called functional-20200910153511-83042

medya@~/workspace/g1 $ minikube profile list
|---------------------------------|-----------|---------|------------|------|---------|---------|
|             Profile             | VM Driver | Runtime |     IP     | Port | Version | Status  |
|---------------------------------|-----------|---------|------------|------|---------|---------|
| functional-20200910153511-83042 | docker    | docker  | 172.17.0.3 | 8441 | v1.19.0 | Running |
|---------------------------------|-----------|---------|------------|------|---------|--------

when I run minikube ssh I get this error:

medya@~/workspace/g1 $ minikube ssh
🤷  There is no local cluster named "minikube"
👉  To fix this, run: "minikube start"

it would be better that we tell them,

"Profile "Y" was not found. You have a profile named X, did you mean to use that?"
@medyagh medyagh added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 14, 2020
@medyagh medyagh changed the title improve message, when Only existing profile name is NOT minikube improve message, when there is profile name other than "minikube" Sep 14, 2020
@sharifelgamal sharifelgamal added priority/backlog Higher priority than priority/awaiting-more-evidence. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 16, 2020
@a-hilaly
Copy link
Member

/assign

@tstromberg
Copy link
Contributor

@a-hilaly - are you still working on this?

@sachinkumarsingh092
Copy link

sachinkumarsingh092 commented Oct 24, 2020

As the default profile is minikube, Profile Y will always be minikube. I just have to display the name of the existing cluster profile which is Profile X.
Also, should I remove the message "There is no local cluster named "minikube"" from above and insert "Profile "Y" was not found. You have a profile named X, did you mean to use that?" message instead or is it an additional message with the existing one?
Am I missing something?

@a-hilaly
Copy link
Member

@tstromberg No enough progress to send a PR, i don't expect to have anytime this week. Please feel free to reassign if someone can ship it faster :)
/unassign

@peterlin741
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants