windows: minikube ssh taking extremely long

[medyagh]

minikube ssh pwd takes 17 seconds on windows in Azure

this is HyperV driver

PS C:\Users\jenkins>
PS C:\Users\jenkins> Measure-Command { minikube.exe ssh pwd}


Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 17
Milliseconds      : 625
Ticks             : 176255191
TotalDays         : 0.000203999063657407
TotalHours        : 0.00489597752777778
TotalMinutes      : 0.293758651666667
TotalSeconds      : 17.6255191
TotalMilliseconds : 17625.5191

and for docker driver 4 seconds

PS C:\Users\jenkins> Measure-Command { minikube.exe ssh pwd}


Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 4
Milliseconds      : 693
Ticks             : 46930265
TotalDays         : 5.43174363425926E-05
TotalHours        : 0.00130361847222222
TotalMinutes      : 0.0782171083333333
TotalSeconds      : 4.6930265
TotalMilliseconds : 4693.0265

This bug also makes minikube cache tests to fail too.

[medyagh]

I suspect this be side effect of #8907
as I see the Pr that was merged right before that PR (#9019) does NOT fail on the minikube SSH test.

this should have not have happend, we had integration test for it and we merged despite failures.

CC: @sharifelgamal

[sharifelgamal]

MacOS:
Before

time mk ssh pwd
/home/docker

real	0m1.628s
user	0m0.183s
sys	0m0.521s

After

time mk ssh pwd
/home/docker

real	0m1.570s
user	0m0.179s
sys	0m0.139s

[sharifelgamal]

Windows:
Before

Measure-Command{.\out\minikube.exe ssh pwd}


Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 0
Milliseconds      : 930
Ticks             : 9308689
TotalDays         : 1.07739456018519E-05
TotalHours        : 0.000258574694444444
TotalMinutes      : 0.0155144816666667
TotalSeconds      : 0.9308689
TotalMilliseconds : 930.8689

After

 Measure-Command{.\out\minikube.exe ssh pwd}


Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 0
Milliseconds      : 935
Ticks             : 9354871
TotalDays         : 1.08273969907407E-05
TotalHours        : 0.000259857527777778
TotalMinutes      : 0.0155914516666667
TotalSeconds      : 0.9354871
TotalMilliseconds : 935.4871

[sharifelgamal]

Linux:
NOTE: Linux doesn't respect the native-ssh flag at all, with or without the new code
Before (hardcoded to native)

time mk ssh pwd
/home/docker

real	0m0.612s
user	0m0.224s
sys	0m0.311s

After (hardcoded to external)

time mk ssh pwd
/home/docker

real	0m1.143s
user	0m0.216s
sys	0m0.120s

[medyagh]

with native-ssh false and true on windows hypever-7 machine azure.

PS C:\Users\jenkins> Measure-Command {minikube.exe ssh --native-ssh=false pwd}



Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 21
Milliseconds      : 5
Ticks             : 210054702
TotalDays         : 0.000243118868055556
TotalHours        : 0.00583485283333333
TotalMinutes      : 0.35009117
TotalSeconds      : 21.0054702
TotalMilliseconds : 21005.4702



PS C:\Users\jenkins> Measure-Command {minikube.exe ssh --native-ssh=true pwd}


Days              : 0
Hours             : 0
Minutes           : 0
Seconds           : 17
Milliseconds      : 704
Ticks             : 177047787
TotalDays         : 0.000204916420138889
TotalHours        : 0.00491799408333333
TotalMinutes      : 0.295079645
TotalSeconds      : 17.7047787
TotalMilliseconds : 17704.7787

[medyagh]

we fixed it