Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document minikube docker driver version requirements #9077

Open
afbjorklund opened this issue Aug 25, 2020 · 9 comments
Open

Document minikube docker driver version requirements #9077

afbjorklund opened this issue Aug 25, 2020 · 9 comments
Labels
co/docker-driver Issues related to kubernetes in container help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@afbjorklund
Copy link
Collaborator

afbjorklund commented Aug 25, 2020

Kubernetes itself supports ancient versions, but KIC doesn't really...

kubeadm says:

On each of your machines, install Docker. Version 19.03.11 is recommended, but 1.13.1, 17.03, 17.06, 17.09, 18.06 and 18.09 are known to work as well. Keep track of the latest verified Docker version in the Kubernetes release notes.

Should verify the Docker version, like we do with the Podman version ?

And have a similar recommendation for minikube, on the driver page.


EDIT: I don't think we want to keep supporting 17.03 - 18.09 - or even earlier.

17.03.0-ce
2017-03-01
This release includes bugfixes for 1.13.1 but there are no major feature additions and the API version stays the same.
Upgrading from Docker 1.13.1 to 17.03.0 is expected to be simple and low-risk.

19.03.1
2019-07-25
Security
Fixed loading of nsswitch based config inside chroot under Glibc. CVE-2019-14271

So the easiest would be to require Docker Engine 19.03+ or Docker Desktop 2.1+ ?

Docker Desktop Community 2.1.0.1
2019-08-08
Upgrades
Docker 19.03.1
Kubernetes 1.14.3

Otherwise we need to look at version and API, and implement workarounds.

@afbjorklund afbjorklund added co/docker-driver Issues related to kubernetes in container kind/documentation Categorizes issue or PR as related to documentation. labels Aug 25, 2020
@medyagh
Copy link
Member

medyagh commented Aug 31, 2020

machines, install Docker. Version 19.03.11 is recommended, but 1.13.1, 17.03, 17.06, 17.09, 18.06 and 18.09 are known to work as well. Keep track of the latest verified Docker version in the Kuber

Docker has been less problem in version, plus this seems to be more related to the docker inside minikube rather than the outside docker verison.

we could add a link to the kubeadm from our docs, with the version

@afbjorklund
Copy link
Collaborator Author

Docker has been less problem in version, plus this seems to be more related to the docker inside minikube rather than the outside docker verison.

I should have been more specific, what I meant was that we need (want?) to be more strict with the versions used for the Docker driver.

The reason for this ticket was the cp command missing in earlier versions like 17.03: #9075. So the easiest would be to require Docker 19.03 ?

@priyawadhwa priyawadhwa added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Sep 8, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 7, 2020
@afbjorklund afbjorklund added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Dec 12, 2020
@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Dec 19, 2020

We need to check against outdated minor Docker versions, at least.

It should be OK with 18.09 and 19.03 - as long as they are updated...

@afbjorklund
Copy link
Collaborator Author

/remove-lifecycle stale

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 19, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 18, 2021
@spowelljr spowelljr added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Apr 21, 2021
@sharifelgamal sharifelgamal removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. kind/feature Categorizes issue or PR as related to a new feature. labels Apr 28, 2021
@sharifelgamal
Copy link
Collaborator

I do think this is valuable information, it would be an easy check to make as well.

@medyagh
Copy link
Member

medyagh commented Apr 28, 2021

i think we should check if the very old docker versions fails or not, we added support for ancient docker versions in a PR that we might not wanna block users anymore but I would be okay with informing the user if their docker is more than 2 years old they might wanna look into upgrading it.

@spowelljr spowelljr added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/docker-driver Issues related to kubernetes in container help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

7 participants