Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration test for docker-env consumers such as Skaffold #8752

Closed
tstromberg opened this issue Jul 17, 2020 · 0 comments · Fixed by #8779
Closed

Add integration test for docker-env consumers such as Skaffold #8752

tstromberg opened this issue Jul 17, 2020 · 0 comments · Fixed by #8779
Assignees
@priyawadhwa
Labels
area/testing july-chill kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@tstromberg
Copy link
Contributor

To avoid breakages like the ones fixed by #8531 - we should include a consumption integration check for 3rd party systems like Skaffold or Tilt to ensure that we do not break them.
@priyawadhwa priyawadhwa self-assigned this Jul 20, 2020
@priyawadhwa priyawadhwa mentioned this issue Jul 20, 2020
Merged
@tstromberg tstromberg added area/testing kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@priyawadhwa priyawadhwa

Labels
area/testing july-chill kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add integration test to test against latest skaffold release priyawadhwa/minikube
2 participants
@tstromberg @priyawadhwa