-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--extra-config doesn't work on preexisting clusters #8661
Comments
@franck102 thank you for reporting this, it does appear to be a bug. while I am not sure the root cause I would be happy to review a PR that fixes this btw are you sure the format of the extra option is correct I am not familiar with [--extra-config=apiserver.v=1] and is there a reason you put that on in a bracket [ ] ? and also could you provide me a way to verify this myself, what is the expected result if you set this paramter? |
/triage needs-information |
I added the brackets to indicate the result was the same with or without the switch:
... both give the same result. To verify, I would expect that with the -v=1 flag supplied to the apiserver, trace entries like the one below would not appear in the pod's logs anymore:
|
I had a similar issue yesterday. Maybe the root cause is the same. Can you check your ~/.minikube/profiles/minikube/config.json file? There should be an section named "ExtraOptions" which contains thec. If it doesn't contain your apiserver.v=1 option then it looks like the same root cause. In my case I added a few "--extra-config" flags later on after I started minikube for the first time with a "--extra-config" flag. It never used those new flags until I changed the config.json file. It seems the 'minikube' command does never pickup those additional flags you add or remove after having provided some flag. You can even use 'minikube start' and it will use those old flags from the config.json file. |
Is this a dup of #8242? |
It may be, but I don’t know. |
Hey @franck102 I tried to repro this with minikube v1.12.0 by running:
I confirmed that this worked as expected by running:
So the flag is being passed in as expected. Could you see if this works for you? I suspect this will only work on fresh start and not an existing cluster; that issue is being tracked at #8242 |
Hey @franck102 are you still seeing this issue? |
Hi, I experienced the issue with k8s 1.16.3 / minikube 1.12.0. After following this I switched the k8s version to 1.13.10 and minikube api-server could pickup the extra-config for kube-apiserver - i.e. issue didn't happen with k8s 1.13.0. |
Hey @jot-hub I tried with:
and it worked as expected. Could you try upgrading your minikube version? |
Thanks @priyawadhwa for checking! not sure how the parameter makes a difference here |
update: following sequence of commands worked:
so the issue seems to be only with an existing cluster like suggested earlier in this thread |
This issue appears to be a duplicate of #8242, do you mind if we move the conversation there? Ths way we can centralize the content relating to the issue. If you feel that this issue is not in fact a duplicate, please re-open it using Thank you for reporting this! |
The problem started appearing yesterday, stopping / restarting minikube or deleting the apiserver pod doesn't help.
The VM hogs the CPU, and connections to the apiserver are failing (esp. a CreateWatch call from a Java client)
Start minikube with
/usr/local/bin/minikube [--extra-config=apiserver.v=1] --extra-config=kubelet.authentication-token-webhook=true --extra-config=kubelet.authorization-mode=Webhook --extra-config=scheduler.bind-address=0.0.0.0 --extra-config=controller-manager.bind-address=0.0.0.0 start
(same result with or without the apiserver.v=1 extra config)
kubectl -n kube-system logs
Entries are logged at the Trace level: 5mn after starting the cluster the logs have 2300 lines, and VirtualBox uses 284% CPU
Full output of
minikube start
command used, if not already included:😄 minikube v1.11.0 on Darwin 10.14.1
▪ MINIKUBE_ACTIVE_DOCKERD=minikube
✨ Using the virtualbox driver based on existing profile
👍 Starting control plane node minikube in cluster minikube
🔄 Restarting existing virtualbox VM for "minikube" ...
🐳 Preparing Kubernetes v1.18.3 on Docker 19.03.8 ...
▪ apiserver.v=1
▪ kubelet.authentication-token-webhook=true
▪ kubelet.authorization-mode=Webhook
▪ scheduler.bind-address=0.0.0.0
▪ controller-manager.bind-address=0.0.0.0
🔎 Verifying Kubernetes components...
🌟 Enabled addons: dashboard, default-storageclass, ingress, metrics-server, storage-provisioner
🏄 Done! kubectl is now configured to use "minikube"
❗ /usr/local/bin/kubectl is version 1.15.2, which may be incompatible with Kubernetes 1.18.3.
💡 You can also use 'minikube kubectl -- get pods' to invoke a matching version
** minikube config
fma$ minikube config view
The text was updated successfully, but these errors were encountered: