Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invald deployment patch in Ingress nginx tutorial #8452

Closed
sepetrov opened this issue Jun 11, 2020 · 5 comments · Fixed by #8451
Closed

Invald deployment patch in Ingress nginx tutorial #8452

sepetrov opened this issue Jun 11, 2020 · 5 comments · Fixed by #8451
Labels
addon/ingress kind/support Categorizes issue or PR as a support question. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@sepetrov
Copy link
Contributor

sepetrov commented Jun 11, 2020

Following the steps in the tutorial Ingress nginx for TCP and UDP services there are two issues:

  1. Invalid deployment name (fixed in Fix deployment name in ingress Nginx tutorial #8451)
  2. Invalid deployment patch

Invalid deployment patch

After executing the command patching the deployment I received the following error:

$ cat ingress-nginx-controller-patch.yaml

spec:
  template:
    spec:
      containers:
      - name: ingress-nginx-controller
        ports:
         - containerPort: 6379
           hostPort: 6379

$ kubectl patch deployment ingress-nginx-controller --patch "$(cat ingress-nginx-controller-patch.yaml)" -n kube-system

The Deployment "ingress-nginx-controller" is invalid: spec.template.spec.containers[0].image: Required value

minikube version

$ minikube version: v1.11.0

commit: 57e2f55f47effe9ce396cea42a1e0eb4f611ebbd
@medyagh
Copy link
Member

medyagh commented Jun 11, 2020

@epetrov which driver are you using ?

the ingress tutotirals need to consolidated and fixed

@medyagh medyagh added addon/ingress triage/needs-information Indicates an issue needs more information in order to work on it. kind/support Categorizes issue or PR as a support question. labels Jun 11, 2020
@sepetrov
Copy link
Contributor Author

@epetrov which driver are you using ?

@medyagh, virtualbox

@sepetrov
Copy link
Contributor Author

Looks like merging #8451 closed this issue :(

@kirkre
Copy link

kirkre commented Jun 27, 2020

The name was fixed in the tutorial but not the Invalid deployment patch. Does anyone have a working deployment patch? I get the same error as sepetrov, and I am also using the same minikube version. Thanks.

@menems
Copy link

menems commented Jul 1, 2020

@sepetrov , @medyagh Hi it seems that now , the name of the container on the deployment is "controller" not "ingress-nginx-controller"

spec:
  template:
    spec:
      containers:
      - name: controller
        ports:
         - containerPort: 6379
           hostPort: 6379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon/ingress kind/support Categorizes issue or PR as a support question. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants