Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fall-through to next driver if host creation fails #7216

Closed
tstromberg opened this issue Mar 24, 2020 · 1 comment · Fixed by #7389
Closed

Fall-through to next driver if host creation fails #7216

tstromberg opened this issue Mar 24, 2020 · 1 comment · Fixed by #7389
Assignees
@sharifelgamal
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. ux/embedded Embedded UX blockers
Milestone
v1.10.0

Comments

@tstromberg
Copy link
Contributor

On some systems, the preferable driver may be broken in a way that we are unable to detect until host creation.

If cluster creation fails, due to permissions issues for instance, we should delete the cluster and fall through to the next driver.
@tstromberg tstromberg added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. ux/embedded Embedded UX blockers labels Mar 24, 2020
@medyagh
Copy link
Member

medyagh commented Mar 25, 2020

I like this idea !

@priyawadhwa priyawadhwa added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 25, 2020
@tstromberg tstromberg added this to the v1.10.0 milestone Apr 1, 2020
@tstromberg tstromberg mentioned this issue Apr 2, 2020
Closed
@sharifelgamal sharifelgamal mentioned this issue Apr 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharifelgamal sharifelgamal

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. ux/embedded Embedded UX blockers
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging a pull request may close this issue.

fallback to alternate drivers on failure sharifelgamal/minikube
4 participants
@tstromberg @medyagh @priyawadhwa @sharifelgamal