Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change name for func HostPortBinding #7029

Closed
medyagh opened this issue Mar 13, 2020 · 2 comments · Fixed by #7051
Closed

Change name for func HostPortBinding #7029

medyagh opened this issue Mar 13, 2020 · 2 comments · Fixed by #7051
Assignees
@vikkyomkar
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@medyagh
Copy link
Member

medyagh commented Mar 13, 2020

For another PR perhaps, but HostPortBinding may be a poor name for this function, as it sounds like it may be binding to a port rather than fetching information. Perhaps:

oci.ForwardedPort or oci.BoundPort, oci.HostPort?

Originally posted by @tstromberg in #7021
@medyagh medyagh added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Mar 13, 2020
@medyagh
Copy link
Member Author

medyagh commented Mar 13, 2020

I like either BoundPort and ForwadedPort

this should be an easy PR to search and replace.

@medyagh medyagh changed the title Change name for HostPortBinding Change name for func HostPortBinding Mar 13, 2020
@vikkyomkar
Copy link
Contributor

/assign

@vikkyomkar vikkyomkar mentioned this issue Mar 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vikkyomkar vikkyomkar

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Function name "HostPortBinding" changed to "ForwardedPort
2 participants
@medyagh @vikkyomkar