Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preload containerd images #6933

Closed
medyagh opened this issue Mar 7, 2020 · 4 comments
Closed

Preload containerd images #6933

medyagh opened this issue Mar 7, 2020 · 4 comments
Labels
co/preload co/runtime/containerd kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@medyagh
Copy link
Member

medyagh commented Mar 7, 2020

implement preload for containerd for overlay2.
by generating a tar ball with all images for a kubernetes version, similar to our docker runtime.

@medyagh medyagh added co/docker-driver Issues related to kubernetes in container priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Mar 7, 2020
@medyagh medyagh added this to the v1.9.0 March 30th milestone Mar 7, 2020
@afbjorklund afbjorklund added co/runtime/containerd and removed co/docker-driver Issues related to kubernetes in container labels Mar 7, 2020
@tstromberg tstromberg added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 19, 2020
@priyawadhwa priyawadhwa removed this from the v1.9.0 March 24th milestone Mar 20, 2020
@afbjorklund
Copy link
Collaborator

by generating a tar ball with all images for a kubernetes version, similar to our docker runtime.

That is not how the current preload works, though. It just dumps the /var/lib internals (the guts)

func createImageTarball(tarballFilename string) error {
	// directories to save into tarball
	dirs := []string{
		fmt.Sprintf("./lib/docker/%s", dockerStorageDriver),
		"./lib/docker/image",
		"./lib/minikube/binaries",
	}
	args := []string{"exec", profile, "sudo", "tar", "-I", "lz4", "-C", "/var", "-cvf", tarballFilename}
	args = append(args, dirs...)
	cmd := exec.Command("docker", args...)
	cmd.Stdout = os.Stdout
	if err := cmd.Run(); err != nil {
		return errors.Wrapf(err, "tarball cmd: %s", cmd.Args)
	}
	return nil
}

So in this case, it should dump the /var/lib/containerd instead of /var/lib/docker.

It is still a good idea though (generating the image-only tarball), will add a separate issue for it

@afbjorklund afbjorklund added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Apr 18, 2020
@afbjorklund
Copy link
Collaborator

afbjorklund commented Apr 18, 2020

Nobody uses containerd with minikube, and if they do - they could survive without the preload

So lowered the priority.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 17, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/preload co/runtime/containerd kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

6 participants